mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Nariman <narimantos@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
	"Jordy Ubink" <jordyubink@hotmail.nl>, <broonie@kernel.org>,
	<liam.r.girdwood@linux.intel.com>,
	<pierre-louis.bossart@linux.intel.com>,
	<yang.jie@linux.intel.com>, <perex@perex.cz>,
	<hdegoede@redhat.com>
Subject: Re: [PATCH] ASoC: Intel: bytcr_rt5651.c: remove string buffers 'byt_rt5651_cpu_dai_name' and 'byt_rt5651_cpu_dai_name'
Date: Sun, 05 May 2019 09:51:33 +0200	[thread overview]
Message-ID: <s5ha7g1l4oq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190504151652.5213-4-user@elitebook-localhost>

On Sat, 04 May 2019 17:16:52 +0200,
Nariman wrote:
> 
> From: Jordy Ubink <jordyubink@hotmail.nl>
> 
> The snprintf calls filling byt_rt5651_cpu_dai_name / byt_rt5651_cpu_dai_name always fill them with the same string (ssp0-port" resp "rt5651-aif2"). So instead of keeping these buffers around and making the cpu_dai_name / codec_dai_name point to this, simply update the foo_dai_name pointers to directly point to a string constant containing the desired string.
> 
> Signed-off-by: Jordy Ubink <jordyubink@hotmail.nl>

If you submit a patch, please give your own sign-off as well as the
author's one, even if the patch is not written by you.  This is a
legal requirement.


thanks,

Takashi

  reply	other threads:[~2019-05-05  7:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-04 15:16 [PATCH] ASoC: Intel: bytcr_5640.c:Refactored if statement and removed buffer Nariman
2019-05-04 15:16 ` [PATCH] ASoC: Intel: cht_bsw_rt5645.c: Remove buffer and snprintf calls Nariman
2019-05-06 15:24   ` [alsa-devel] " Pierre-Louis Bossart
2019-05-06 15:48     ` Hans de Goede
2019-05-04 15:16 ` [PATCH] ASoC: Intel: bytcr_5640.c: refactored codec_fixup Nariman
2019-05-04 15:16 ` [PATCH] ASoC: Intel: bytcr_rt5651.c: remove string buffers 'byt_rt5651_cpu_dai_name' and 'byt_rt5651_cpu_dai_name' Nariman
2019-05-05  7:51   ` Takashi Iwai [this message]
2019-05-06 15:40     ` Hans de Goede
2019-05-06 15:50       ` Pierre-Louis Bossart
2019-05-06 15:24   ` Pierre-Louis Bossart
2019-05-06 15:21 ` [alsa-devel] [PATCH] ASoC: Intel: bytcr_5640.c:Refactored if statement and removed buffer Pierre-Louis Bossart
2019-05-06 15:43   ` Hans de Goede
2019-05-06 15:50     ` Pierre-Louis Bossart
2019-05-19 17:57 nariman
2019-05-19 17:57 ` [PATCH] ASoC: Intel: bytcr_rt5651.c: remove string buffers 'byt_rt5651_cpu_dai_name' and 'byt_rt5651_cpu_dai_name' nariman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5ha7g1l4oq.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=jordyubink@hotmail.nl \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narimantos@gmail.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®