From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C29C43441 for ; Mon, 26 Nov 2018 16:13:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B8DF205C9 for ; Mon, 26 Nov 2018 16:13:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B8DF205C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726976AbeK0DHv (ORCPT ); Mon, 26 Nov 2018 22:07:51 -0500 Received: from mx2.suse.de ([195.135.220.15]:53612 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726224AbeK0DHv (ORCPT ); Mon, 26 Nov 2018 22:07:51 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6C6F4B05D; Mon, 26 Nov 2018 16:13:16 +0000 (UTC) Date: Mon, 26 Nov 2018 17:13:16 +0100 Message-ID: From: Takashi Iwai To: Yoshinori Sato Cc: Geert Uytterhoeven , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sh: Always enable CONFIG_GENERIC_PCI_IOMAP In-Reply-To: <20181119115910.19390-1-tiwai@suse.de> References: <20181119115910.19390-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Nov 2018 12:59:10 +0100, Takashi Iwai wrote: > > CONFIG_GENERIC_PCI_IOMAP is supposed to be set no matter whether > CONFIG_PCI is present or not. Otherwise the generic header > (asm-generic/pci_iomap.h) won't create dummy functions, and the code > using pci_iomap() and pci_iounmap() will fail due to the lack of the > function definitions / declarations. > > Cc: Geert Uytterhoeven > Signed-off-by: Takashi Iwai This is a gentle reminder for this fix. If anyone has objection against this, I'm going to apply it via sound git tree, as the code there is obviously a trigger of the bug. thanks, Takashi > --- > arch/sh/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig > index f82a4da7adf3..3d5220ad9e46 100644 > --- a/arch/sh/Kconfig > +++ b/arch/sh/Kconfig > @@ -36,6 +36,8 @@ config SUPERH > select RTC_LIB > select GENERIC_ATOMIC64 > select GENERIC_IRQ_SHOW > + select GENERIC_PCI_IOMAP > + select NO_GENERIC_PCI_IOPORT_MAP > select GENERIC_SMP_IDLE_THREAD > select GENERIC_IDLE_POLL_SETUP > select GENERIC_CLOCKEVENTS > @@ -859,8 +861,6 @@ config PCI > bool "PCI support" > depends on SYS_SUPPORTS_PCI > select PCI_DOMAINS > - select GENERIC_PCI_IOMAP > - select NO_GENERIC_PCI_IOPORT_MAP > help > Find out whether you have a PCI motherboard. PCI is the name of a > bus system, i.e. the way the CPU talks to the other stuff inside > -- > 2.19.1 >