From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28573C43142 for ; Thu, 21 Jun 2018 19:45:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF71521D5B for ; Thu, 21 Jun 2018 19:45:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF71521D5B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933187AbeFUTpt (ORCPT ); Thu, 21 Jun 2018 15:45:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:47798 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932710AbeFUTps (ORCPT ); Thu, 21 Jun 2018 15:45:48 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 09455ACA1; Thu, 21 Jun 2018 19:45:47 +0000 (UTC) Date: Thu, 21 Jun 2018 21:45:46 +0200 Message-ID: From: Takashi Iwai To: "Robert Jarzmik" Cc: "Mark Rutland" , "Liam Girdwood" , "Mark Brown" , "Rob Herring" , "Jaroslav Kysela" , , , Subject: Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding In-Reply-To: <20180621154356.5438-2-robert.jarzmik@free.fr> References: <20180621154356.5438-1-robert.jarzmik@free.fr> <20180621154356.5438-2-robert.jarzmik@free.fr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Jun 2018 17:43:56 +0200, Robert Jarzmik wrote: > > Add a devicetree binding for codecs. This is especially useful if the > AC97 bitclk clock is provided by the codec, as it has to be described in > the devicetree description for the ac97 bus code to aquire it. > > Signed-off-by: Robert Jarzmik > --- > Special review query: review the "return of_node_get(node)", which > assumes that upon device removal, of_put_node(dev.of_node) will be > called... Is it really done automagically? I couldn't spot it. thanks, Takashi