From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751945AbdLFQ1i (ORCPT <rfc822;w@1wt.eu>);
        Wed, 6 Dec 2017 11:27:38 -0500
Received: from mx2.suse.de ([195.135.220.15]:34317 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751208AbdLFQ1f (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 Dec 2017 11:27:35 -0500
Date: Wed, 06 Dec 2017 17:27:33 +0100
Message-ID: <s5ha7yvrfd6.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Anna-Maria Gleixner" <anna-maria@linutronix.de>
Cc: "LKML" <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
        <keescook@chromium.org>, "Peter Zijlstra" <peterz@infradead.org>,
        "John Stultz" <john.stultz@linaro.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        "Christoph Hellwig" <hch@lst.de>, "Jaroslav Kysela" <perex@perex.cz>,
        "Ingo Molnar" <mingo@redhat.com>,
        "Takashi Sakamoto" <o-takashi@sakamocchi.jp>
Subject: Re: [PATCH v3 34/36] ALSA/dummy: Replace tasklet with softirq hrtimer
In-Reply-To: <20171129153101.27297-35-anna-maria@linutronix.de>
References: <20171129153101.27297-1-anna-maria@linutronix.de>
        <20171129153101.27297-35-anna-maria@linutronix.de>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 29 Nov 2017 16:30:59 +0100,
Anna-Maria Gleixner wrote:
> 
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> The tasklet is used to defer the execution of snd_pcm_period_elapsed() to
> the softirq context. Using the HRTIMER_MODE_SOFT mode invokes the timer
> callback in softirq context as well which renders the tasklet useless.
> 
> [o-takashi: avoid stall due to a call of hrtimer_cancel() on a callback
>             of hrtimer]
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> Cc: alsa-devel@alsa-project.org
> Cc: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Link: http://lkml.kernel.org/r/20170905161820.jtysvxtfleunbbmf@breakpoint.cc

Feel free to take my ack:
  Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi