mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Vinod Koul <vinod.koul@intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	alsa-devel@alsa-project.org
Subject: Re: [GIT PULL] sound updates for 4.15-rc1
Date: Wed, 15 Nov 2017 12:58:40 +0100	[thread overview]
Message-ID: <s5ha7zn69e7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20171115113742.27b2nvfsbtvv7gfs@sirena.org.uk>

On Wed, 15 Nov 2017 12:37:42 +0100,
Mark Brown wrote:
> 
> On Wed, Nov 15, 2017 at 08:34:09AM +0100, Takashi Iwai wrote:
> 
> > And I believe there are a few more possible cleanups / fixes in the
> > messy Intel ASoC Kconfigs.  For example, SND_SOC_INTEL_SST is almost
> > always set.  The only exception is via SND_SST_ATOM_HIFI2_PLATFORM.
> > But all machine drivers using Atom Hifi2 do set SND_SST_IPC_ACPI,
> > which also requires SND_SOC_INTEL_SST.
> 
> I'm not 100% convinced that the recent changes away from just having the
> only user selectable options be the board ones have really helped that
> much.

Yeah, now it resulted in a mixture of selects and depends, which is a
bad sign.  I'm not against this kind of reorganization but we need to
sort out more.

> Though transitioning back would probably just create more misery.
> It's a real shame that ACPI doesn't have standards for the machine
> descriptions here like DT does, it'd cut down on the amount of stuff
> that needs configuring.

True.  Although I don't think ACPI is the center of the mess in this
case, but rather too many kconfigs is it.

In soc/intel/*, we have the following entries:

as non-selectable ones:
- SND_SST_IPC
- SND_SST_IPC_PCI
- SND_SST_IPC_ACPI
- SND_SOC_INTEL_COMMON
- SND_SOC_INTEL_SST
- SND_SOC_INTEL_SST_FIRMWARE
- SND_SOC_INTEL_SST_ACPI
- SND_SOC_ACPI_INTEL_MATCH

and the selectable ones:
- SND_SOC_INTEL_SST_TOPLEVEL
- SND_SOC_INTEL_HASWELL
- SND_SOC_INTEL_BAYTRAIL
- SND_SST_ATOM_HIFI2_PLATFORM
- SND_SOC_INTEL_SKYLAKE

And yet, there are tons of machine drivers as selectable kconfigs:
- SND_SOC_INTEL_MACH
- SND_MFLD_MACHINE
- SND_SOC_INTEL_HASWELL_MACH
- SND_SOC_INTEL_BDW_RT5677_MACH
- SND_SOC_INTEL_BROADWELL_MACH
- SND_SOC_INTEL_BYT_MAX98090_MACH
- SND_SOC_INTEL_BYT_RT5640_MACH
- SND_SOC_INTEL_BYTCR_RT5640_MACH
- SND_SOC_INTEL_BYTCR_RT5651_MACH
- SND_SOC_INTEL_CHT_BSW_RT5672_MACH
- SND_SOC_INTEL_CHT_BSW_RT5645_MACH
- SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH
- SND_SOC_INTEL_BYT_CHT_DA7213_MACH
- SND_SOC_INTEL_BYT_CHT_ES8316_MACH
- SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH
- SND_SOC_INTEL_SKL_RT286_MACH
- SND_SOC_INTEL_SKL_NAU88L25_SSM4567_MACH
- SND_SOC_INTEL_SKL_NAU88L25_MAX98357A_MACH
- SND_SOC_INTEL_BXT_DA7219_MAX98357A_MACH
- SND_SOC_INTEL_BXT_RT298_MACH
- SND_SOC_INTEL_KBL_RT5663_MAX98927_MACH
- SND_SOC_INTEL_KBL_RT5663_RT5514_MAX98927_MACH


We should begin with thinking of which entries (and layer) to be
selectable, and which not.


Takashi

  reply	other threads:[~2017-11-15 11:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 14:51 Takashi Iwai
2017-11-15  2:40 ` Linus Torvalds
2017-11-15  7:34   ` Takashi Iwai
2017-11-15 11:37     ` Mark Brown
2017-11-15 11:58       ` Takashi Iwai [this message]
2017-11-15 12:16         ` Mark Brown
2017-11-15 13:16           ` Takashi Iwai
2017-11-15 13:33             ` Mark Brown
2017-11-15 13:37               ` Takashi Iwai
     [not found]         ` <20171115152411.GI3187@localhost>
2017-11-15 15:37           ` Mark Brown
2017-11-15 16:19           ` [alsa-devel] " Pierre-Louis Bossart
2017-11-15 17:11             ` Linus Torvalds
2017-11-16 14:55     ` Pierre-Louis Bossart
2017-11-16 15:10       ` Takashi Iwai
2017-11-16 20:27         ` Pierre-Louis Bossart
2017-11-17 14:24           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5ha7zn69e7.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome