From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752698AbdHVUTn (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Aug 2017 16:19:43 -0400
Received: from mx2.suse.de ([195.135.220.15]:43748 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751865AbdHVUTl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Aug 2017 16:19:41 -0400
Date: Tue, 22 Aug 2017 22:19:39 +0200
Message-ID: <s5ha82rs6ck.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
        alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Julia Lawall <Julia.Lawall@lip6.fr>
Subject: Re: [alsa-devel] [PATCH] ALSA: via82xx: Use common error handling code in snd_via82xx_create()
In-Reply-To: <20170822201400.lw3bcjlvx4lzlq5d@mwanda>
References: <2332472c-61d2-8c21-bf46-5c80745d6380@users.sourceforge.net>
        <20170822190757.76e5edh5t6tgvzpu@mwanda>
        <d9b9dc7e-9c00-3f1d-f6f8-a2e67110c449@users.sourceforge.net>
        <20170822201400.lw3bcjlvx4lzlq5d@mwanda>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 22 Aug 2017 22:16:12 +0200,
Dan Carpenter wrote:
> 
> On Tue, Aug 22, 2017 at 10:05:37PM +0200, SF Markus Elfring wrote:
> > >> @@ -1121,30 +1121,27 @@ static int snd_via82xx_create(struct snd_card *card,
> > >>  
> > >>  	if ((err = pci_request_regions(pci, card->driver)) < 0) {
> > >>  		kfree(chip);
> > >> -		pci_disable_device(pci);
> > >> -		return err;
> > >> +		goto disable_device;
> 
> Ah, you're right.  It's not leaking.  I thought you deleted the
> kfree(chip);...

Well, this also suggests something wrong by the patch...

If you can't achieve it cleanly, better not to touch it in a
half-baked way.


Takashi