From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755211AbbL3Vuy (ORCPT ); Wed, 30 Dec 2015 16:50:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:60767 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbbL3Vux (ORCPT ); Wed, 30 Dec 2015 16:50:53 -0500 Date: Wed, 30 Dec 2015 22:50:52 +0100 Message-ID: From: Takashi Iwai To: "Julia Lawall" Cc: "Jaroslav Kysela" , , , Subject: Re: [PATCH] ALSA: atiixp: constify atiixp_dma_ops structures In-Reply-To: <1451470917-30436-1-git-send-email-Julia.Lawall@lip6.fr> References: <1451470917-30436-1-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Dec 2015 11:21:57 +0100, Julia Lawall wrote: > > The atiixp_dma_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Applied, thanks. Takashi > > --- > sound/pci/atiixp.c | 6 +++--- > sound/pci/atiixp_modem.c | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/sound/pci/atiixp.c b/sound/pci/atiixp.c > index 1028fc8..2ce0022 100644 > --- a/sound/pci/atiixp.c > +++ b/sound/pci/atiixp.c > @@ -1219,7 +1219,7 @@ static struct ac97_pcm atiixp_pcm_defs[] = { > }, > }; > > -static struct atiixp_dma_ops snd_atiixp_playback_dma_ops = { > +static const struct atiixp_dma_ops snd_atiixp_playback_dma_ops = { > .type = ATI_DMA_PLAYBACK, > .llp_offset = ATI_REG_OUT_DMA_LINKPTR, > .dt_cur = ATI_REG_OUT_DMA_DT_CUR, > @@ -1228,7 +1228,7 @@ static struct atiixp_dma_ops snd_atiixp_playback_dma_ops = { > .flush_dma = atiixp_out_flush_dma, > }; > > -static struct atiixp_dma_ops snd_atiixp_capture_dma_ops = { > +static const struct atiixp_dma_ops snd_atiixp_capture_dma_ops = { > .type = ATI_DMA_CAPTURE, > .llp_offset = ATI_REG_IN_DMA_LINKPTR, > .dt_cur = ATI_REG_IN_DMA_DT_CUR, > @@ -1237,7 +1237,7 @@ static struct atiixp_dma_ops snd_atiixp_capture_dma_ops = { > .flush_dma = atiixp_in_flush_dma, > }; > > -static struct atiixp_dma_ops snd_atiixp_spdif_dma_ops = { > +static const struct atiixp_dma_ops snd_atiixp_spdif_dma_ops = { > .type = ATI_DMA_SPDIF, > .llp_offset = ATI_REG_SPDF_DMA_LINKPTR, > .dt_cur = ATI_REG_SPDF_DMA_DT_CUR, > diff --git a/sound/pci/atiixp_modem.c b/sound/pci/atiixp_modem.c > index 27ed678..c534552 100644 > --- a/sound/pci/atiixp_modem.c > +++ b/sound/pci/atiixp_modem.c > @@ -970,7 +970,7 @@ static struct snd_pcm_ops snd_atiixp_capture_ops = { > .pointer = snd_atiixp_pcm_pointer, > }; > > -static struct atiixp_dma_ops snd_atiixp_playback_dma_ops = { > +static const struct atiixp_dma_ops snd_atiixp_playback_dma_ops = { > .type = ATI_DMA_PLAYBACK, > .llp_offset = ATI_REG_MODEM_OUT_DMA1_LINKPTR, > .dt_cur = ATI_REG_MODEM_OUT_DMA1_DT_CUR, > @@ -979,7 +979,7 @@ static struct atiixp_dma_ops snd_atiixp_playback_dma_ops = { > .flush_dma = atiixp_out_flush_dma, > }; > > -static struct atiixp_dma_ops snd_atiixp_capture_dma_ops = { > +static const struct atiixp_dma_ops snd_atiixp_capture_dma_ops = { > .type = ATI_DMA_CAPTURE, > .llp_offset = ATI_REG_MODEM_IN_DMA_LINKPTR, > .dt_cur = ATI_REG_MODEM_IN_DMA_DT_CUR, > >