From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755586AbaFWQMR (ORCPT ); Mon, 23 Jun 2014 12:12:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52574 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754060AbaFWQMP (ORCPT ); Mon, 23 Jun 2014 12:12:15 -0400 Date: Mon, 23 Jun 2014 18:12:13 +0200 Message-ID: From: Takashi Iwai To: Vincent Heuken Cc: perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Sound: Core: fixed assignment in if condition style error in hwdep.c In-Reply-To: <1403279435-31231-1-git-send-email-me@vincentheuken.com> References: <1403279435-31231-1-git-send-email-me@vincentheuken.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 20 Jun 2014 08:50:35 -0700, Vincent Heuken wrote: > > This is a patch to the hwdep.c file that fixes one instance of > the following error: > ERROR: do not use assignment in if condition > > It also, incidentally, fixes one instance of the following warning: > WARNING: line over 80 characters > > Signed-off-by: Vincent Heuken If this is a preliminary work for any real fix, I'd happily apply this patch. But, if it's only about a coding style fix, I won't buy it alone. Let me know if it's the former case. thanks, Takashi > --- > sound/core/hwdep.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c > index 69459e5..42d8324 100644 > --- a/sound/core/hwdep.c > +++ b/sound/core/hwdep.c > @@ -527,7 +527,9 @@ static void __init snd_hwdep_proc_init(void) > { > struct snd_info_entry *entry; > > - if ((entry = snd_info_create_module_entry(THIS_MODULE, "hwdep", NULL)) != NULL) { > + entry = snd_info_create_module_entry(THIS_MODULE, "hwdep", NULL); > + > + if (entry != NULL) { > entry->c.text.read = snd_hwdep_proc_read; > if (snd_info_register(entry) < 0) { > snd_info_free_entry(entry); > -- > 2.0.0 >