From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933753AbaDCGNs (ORCPT ); Thu, 3 Apr 2014 02:13:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55645 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933607AbaDCGNr (ORCPT ); Thu, 3 Apr 2014 02:13:47 -0400 Date: Thu, 03 Apr 2014 08:13:46 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: Jiri Slaby , Samo Pogacnik , Arnd Bergmann , Jean Delvare , Struan Bartlett , Andreas Schwab , gnomes@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ttyprintk: Allow built as a module In-Reply-To: <20140402193222.GA26425@kroah.com> References: <1396434582-30799-1-git-send-email-tiwai@suse.de> <1396434582-30799-2-git-send-email-tiwai@suse.de> <20140402193222.GA26425@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 2 Apr 2014 12:32:22 -0700, Greg Kroah-Hartman wrote: > > On Wed, Apr 02, 2014 at 12:29:42PM +0200, Takashi Iwai wrote: > > The driver is well written to be used as a module, just the exit call > > is missing. > > > > Signed-off-by: Takashi Iwai > > --- > > drivers/char/Kconfig | 2 +- > > drivers/char/ttyprintk.c | 13 ++++++++++++- > > 2 files changed, 13 insertions(+), 2 deletions(-) > > There was some reason we didn't do this back when the code was accepted, > but I really can't remember why. > > If you have tested this out, I don't have any objections to taking these > patches, thanks. The module worked fine with my quick tests (load/unload/feed something via /dev/ttyprintk), at least. But it'd be helpful if anyone remembers and clarifies. thanks, Takashi