From: Takashi Iwai <tiwai@suse.de>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org,
will.deacon@arm.com, catalin.marinas@arm.com, olof@lixom.net,
sudeep.karkadanagesha@arm.com
Subject: Re: [PATCH] drivers: clocksource: Hide arm_arch_timer eventstream Kconfig on non-ARM
Date: Thu, 21 Nov 2013 10:20:43 +0100 [thread overview]
Message-ID: <s5ha9gyi00k.wl%tiwai@suse.de> (raw)
In-Reply-To: <1384977723-32344-1-git-send-email-sboyd@codeaurora.org>
At Wed, 20 Nov 2013 12:02:03 -0800,
Stephen Boyd wrote:
>
> Pavel Machek reports that this config is exposed on x86 where the
> ARM architected timers aren't even present. Make it depend on the
> ARM architected timers being selected so that non-ARM builds
> aren't asked about it.
>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/clocksource/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index bdb953e..5c07a56 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -87,6 +87,7 @@ config ARM_ARCH_TIMER
> config ARM_ARCH_TIMER_EVTSTREAM
> bool "Support for ARM architected timer event stream generation"
> default y if ARM_ARCH_TIMER
> + depends on ARM_ARCH_TIMER
We can drop "if ARM_ARCH_TIMER" in "default y" line now.
But do we need "default y" at the first place?
Takashi
prev parent reply other threads:[~2013-11-21 9:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 19:21 Support for ARM architected timer event stream generation on x86 Pavel Machek
2013-11-20 20:02 ` [PATCH] drivers: clocksource: Hide arm_arch_timer eventstream Kconfig on non-ARM Stephen Boyd
2013-11-20 21:09 ` Pavel Machek
2013-11-20 21:16 ` Daniel Lezcano
2013-11-21 9:20 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha9gyi00k.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=pavel@ucw.cz \
--cc=sboyd@codeaurora.org \
--cc=sudeep.karkadanagesha@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®