From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932519Ab3GRPwB (ORCPT ); Thu, 18 Jul 2013 11:52:01 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40134 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759002Ab3GRPwA (ORCPT ); Thu, 18 Jul 2013 11:52:00 -0400 Date: Thu, 18 Jul 2013 17:53:12 +0200 Message-ID: From: Takashi Iwai To: Chris J Arges Cc: Torstein Hegge , alsa-devel@alsa-project.org, martin@meltin.net, Jaroslav Kysela , Eldad Zack , Trulan Martin , Damien Zammit , Mark Hills , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: Add quirk for Focusrite Scarlett 18i8 In-Reply-To: <51E806CD.9080009@gmail.com> References: <1374095558-9949-1-git-send-email-christopherarges@gmail.com> <20130717235323.GA21885@pvv.ntnu.no> <51E806CD.9080009@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 18 Jul 2013 10:16:29 -0500, Chris J Arges wrote: > > On 07/17/2013 06:53 PM, Torstein Hegge wrote: > > On Wed, Jul 17, 2013 at 16:12:12 -0500, Chris J Arges wrote: > >> This patch is similar to commit 1762a59d8e8b5e99f6f4a0f292b40f3cacb108ba. > >> The same non-standard interface descriptor causes snd_usb_create_mixer() > >> to fail for the Focusrite Scarlett 18i8 as well. > > > > Did you test this on a recent kernel? I don't think this quirk or the quirk > > introduced by 1762a59d "ALSA: usb-audio: Add quirk for Focusrite Scarlett > > 18i6" is necessary since kernel 3.9, as it includes: > > > > 4d7b86c98 "ALSA: snd-usb: mixer: propagate errors up the call chain" > > 83ea5d18d "ALSA: snd-usb: mixer: ignore -EINVAL in snd_usb_mixer_controls()" > > 61ac51301 "ALSA: usb: Parse UAC2 extension unit like for UAC1" > > > > Those were tested on a Focusrite Scarlett 8i6, but the lsusb output > > from 18i6 and 8i6 looks similar, > > http://www.mail-archive.com/alsa-user@lists.sourceforge.net/msg29426.html > > http://www.mail-archive.com/alsa-user@lists.sourceforge.net/msg27776.html > > I'm guessing the 18i8 isn't that different. > > > > Re-testing this, I see that you are right. The mixer still doesn't work, > but at least its usable for playback/recording/midi. > Ignore this patch then. OK, thanks for a quick update. Takashi