From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753322Ab1K1Rib (ORCPT ); Mon, 28 Nov 2011 12:38:31 -0500 Received: from cantor2.suse.de ([195.135.220.15]:51010 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878Ab1K1Ria (ORCPT ); Mon, 28 Nov 2011 12:38:30 -0500 Date: Mon, 28 Nov 2011 18:38:28 +0100 Message-ID: From: Takashi Iwai To: Linus Torvalds Cc: Mark Brown , Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] sound updates for 3.2-rc4 In-Reply-To: References: User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 28 Nov 2011 08:58:30 -0800, Linus Torvalds wrote: > > On Mon, Nov 28, 2011 at 5:38 AM, Takashi Iwai wrote: > > > > This includes a few trivial fixes for ASoC, an sta32x coef setup fix, > > and a few HD-audio fixes (including the fix for MacBook Air). > > Btw, that one seems to have a bug, just looking at the patch: > > static const char * const cs420x_models[CS420X_MODELS] = { > [CS420X_MBP53] = "mbp53", > [CS420X_MBP55] = "mbp55", > [CS420X_IMAC27] = "imac27", > + [CS420X_IMAC27] = "apple", > [CS420X_AUTO] = "auto", > }; > > Spot the error? Yeah, it was already fixed by the patch from Dan Carpenter, already included in this pull request. thanks, Takashi