From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752511Ab1HHKrN (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Aug 2011 06:47:13 -0400
Received: from cantor2.suse.de ([195.135.220.15]:37427 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750823Ab1HHKrL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Aug 2011 06:47:11 -0400
Date: Mon, 08 Aug 2011 12:47:09 +0200
Message-ID: <s5haabkgoya.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: stufever@gmail.com
Cc: linux-kernel@vger.kernel.org, perex@perex.cz,
        Wang Shaoyan <wangshaoyan.pt@taobao.com>
Subject: Re: [PATCH] sound: don't use the deprecated function check_region
In-Reply-To: <1312800195-7374-1-git-send-email-wangshaoyan.pt@taobao.com>
References: <1312800195-7374-1-git-send-email-wangshaoyan.pt@taobao.com>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon,  8 Aug 2011 18:43:15 +0800,
stufever@gmail.com wrote:
> 
> From: Wang Shaoyan <wangshaoyan.pt@taobao.com>
> 
>   sound/oss/pss.c: In function 'configure_nonsound_components':
>   sound/oss/pss.c:676: warning: 'check_region' is deprecated (declared at include/linux/ioport.h:201)
> 
> Signed-off-by: Wang Shaoyan <wangshaoyan.pt@taobao.com>

Thanks, it's getting better, but a still bit things to fix...

> ---
>  sound/oss/pss.c |   11 +++++------
>  1 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/sound/oss/pss.c b/sound/oss/pss.c
> index 9b800ce..55bfea6 100644
> --- a/sound/oss/pss.c
> +++ b/sound/oss/pss.c
> @@ -673,7 +673,7 @@ static void configure_nonsound_components(void)
>  
>  	if (pss_cdrom_port == -1) {	/* If cdrom port enablation wasn't requested */
>  		printk(KERN_INFO "PSS: CDROM port not enabled.\n");
> -	} else if (check_region(pss_cdrom_port, 2)) {
> +	} else if (!request_region(pss_cdrom_port, 2, "PSS CDROM")) {
>  		printk(KERN_ERR "PSS: CDROM I/O port conflict.\n");

In the error path, set pss_cdrom_port to -1 so that it won't be
released wrongly later.

>  	} else {
>  		set_io_base(devc, CONF_CDROM, pss_cdrom_port);
> @@ -1223,8 +1223,7 @@ static int __init init_pss(void)
>  
>  static void __exit cleanup_pss(void)
>  {
> -	if(!pss_no_sound)
> -	{
> +	if (!pss_no_sound) {
>  		if(fw_load && pss_synth)
>  			vfree(pss_synth);
>  		if(pssmss)

Not necessary to fix the coding style in the same patch.

> @@ -1232,10 +1231,10 @@ static void __exit cleanup_pss(void)
>  		if(pssmpu)
>  			unload_pss_mpu(&cfg_mpu);
>  		unload_pss(&cfg);
> -	}
> +	} else
> +		release_region(pss_cdrom_port, 2);

Call this only when pss_cdrom_port has a valid value.


thanks,

Takashi