From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1755275AbYIDHEY@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755275AbYIDHEY (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Sep 2008 03:04:24 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751261AbYIDHEP
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 4 Sep 2008 03:04:15 -0400
Received: from ns2.suse.de ([195.135.220.15]:58838 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751048AbYIDHEP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Sep 2008 03:04:15 -0400
Date: Thu, 04 Sep 2008 09:04:13 +0200
Message-ID: <s5habeoo0ia.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Pavel Hofman <pavel.hofman@insite.cz>
Cc: Wei Ni <wni@nvidia.com>, Peer Chen <pchen@nvidia.com>,
       alsa-devel <alsa-devel@alsa-project.org>,
       linux-kernel <linux-kernel@vger.kernel.org>,
       akpm <akpm@linux-foundation.org>
Subject: Re: [alsa-devel] [PATCH] add the nvidia HDMI codec driver for	MCP77/79
In-Reply-To: <48BE7EE4.8020800@insite.cz>
References: <200809031558156739794@gmail.com>
	<s5hhc8xpq6z.wl%tiwai@suse.de>
	<15F501D1A78BD343BE8F4D8DB854566B31F8F744@hkemmail01.nvidia.com>
	<s5h4p4xph6x.wl%tiwai@suse.de>
	<48BE7EE4.8020800@insite.cz>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 03 Sep 2008 14:11:16 +0200,
Pavel Hofman wrote:
> 
> 
> >> ......
> >> According to these codes, It only can get the realtek codec and can not
> >> get hdmi codec, if just change azx_max_codecs[AZX_DRIVER_NVIDIA] to 4
> >> I think if remove "if (!audio_codecs)", it will be better, and I only
> >> need to chang azx_max_codecs[AZX_DRIVER_NVIDIA] to 4
> > 
> > Well, the check is there for a good reason.
> > 
> > There are many machines with broken BIOS reporting the 4th slot
> > available although it isn't actually.  It's a workaround to skip such
> > a bogus information.  So, it cannot be changed so easily.
> > 
> > We need to sort out this in a better way...  Oh well.
> 
> 
> Please, please, put the above information as a comment to the respective 
> place. These "hacks" should be commented :)

I changed that code yesterday with a little bit more comment.

Wei, Peer, could you regenerate the patch based on the latest sound
git tree?

    git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git

or use the snapshot tarball from

    ftp://ftp.kernel.org/pub/linux/tiwai/snapshot/

This already contains the fix for the 4th slot probe on Nvidia
chipset.


thanks,

Takashi