From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759964AbYD3MFK (ORCPT ); Wed, 30 Apr 2008 08:05:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759794AbYD3MEz (ORCPT ); Wed, 30 Apr 2008 08:04:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46619 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763116AbYD3MEy (ORCPT ); Wed, 30 Apr 2008 08:04:54 -0400 Date: Wed, 30 Apr 2008 14:04:52 +0200 Message-ID: From: Takashi Iwai To: Ingo Molnar Cc: Mauro Carvalho Chehab , Andrew Morton , linux-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com, linux-kernel@vger.kernel.org, Mike Galbraith Subject: Re: [patch, -git] media/video/sound build fix, TEA5761/TEA5767 In-Reply-To: <20080430111337.GA9170@elte.hu> References: <20080430110115.GA5633@elte.hu> <20080430111337.GA9170@elte.hu> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 30 Apr 2008 13:13:37 +0200, Ingo Molnar wrote: > > > * Ingo Molnar wrote: > > > x86.git randconfig testing found the following new build error in > > latest -git: > > updated fix below - another randconfig also pointed it out that there's > an I2C dependency. (I cannot possibly do a full analysis of the > dependencies of this code so i keep fixing up dependencies as they > occur.) > > Ingo > > ---------------------> > Subject: media/video/sound build fix, TEA5761/TEA5767 > From: Ingo Molnar > Date: Wed Apr 30 12:44:02 CEST 2008 > > x86.git randconfig testing found the following build error: > > drivers/built-in.o: In function `v4l2_i2c_drv_attach_legacy': > tuner-core.c:(.text+0x1a829d): undefined reference to `v4l2_i2c_attach' > drivers/built-in.o: In function `tuner_command': > tuner-core.c:(.text+0x1a971c): undefined reference to `v4l_printk_ioctl' > > the reason is that the TEA5761/TEA5767 tuner code is dependent on > (legacy?) V4L infrastructure like v4l2_i2c_attach, by virtue of > drivers/media/video/tuner-core.c including media/v4l2-i2c-drv-legacy.h > and ./sound/i2c/other/Makefile doing: > > snd-tea575x-tuner-objs := tea575x-tuner.o > > for now i solved this via adding a VIDEO_V4L2_COMMON dependency > to MEDIA_TUNER - but i suspect there might be a better fix as well. > > Signed-off-by: Ingo Molnar I guess this patch is also unnecessary if the reverse selection from fm801-tea575x is replaced with depend by my patch. Then VIDEO_V4L2_COMMON and I2C have to be turned on as the dependency of VIDEO_V4L1. thanks, Takashi > --- > drivers/media/common/tuners/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux/drivers/media/common/tuners/Kconfig > =================================================================== > --- linux.orig/drivers/media/common/tuners/Kconfig > +++ linux/drivers/media/common/tuners/Kconfig > @@ -20,7 +20,7 @@ config MEDIA_ATTACH > config MEDIA_TUNER > tristate > default DVB_CORE || VIDEO_DEV > - depends on DVB_CORE || VIDEO_DEV > + depends on (DVB_CORE || VIDEO_DEV) && VIDEO_V4L2_COMMON && I2C > select MEDIA_TUNER_XC2028 if !MEDIA_TUNER_CUSTOMIZE > select MEDIA_TUNER_XC5000 if !MEDIA_TUNER_CUSTOMIZE > select MEDIA_TUNER_MT20XX if !MEDIA_TUNER_CUSTOMIZE > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >