From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932744AbWLSJ72 (ORCPT ); Tue, 19 Dec 2006 04:59:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932743AbWLSJ71 (ORCPT ); Tue, 19 Dec 2006 04:59:27 -0500 Received: from cantor.suse.de ([195.135.220.2]:50508 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932744AbWLSJ71 (ORCPT ); Tue, 19 Dec 2006 04:59:27 -0500 Date: Tue, 19 Dec 2006 10:59:15 +0100 Message-ID: From: Takashi Iwai To: Adrian Bunk Cc: George Talusan , perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [Alsa-devel] sound/isa/cmi8330.c: dead ENABLE_SB_MIXER code In-Reply-To: <20061204160434.GF30290@stusta.de> References: <20061204160434.GF30290@stusta.de> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 4 Dec 2006 17:04:34 +0100, Adrian Bunk wrote: > > In sound/isa/cmi8330.c, the ENABLE_SB_MIXER code is currently never > used. > > What's the story behind this? > Should ENABLE_SB_MIXER be enabled? > Or the code be removed? CMI8330 has a dual interface for SB and Adlib modes. The mixer can also behave differently according to the mode. The current code has mixer elements corresponding to both modes. However, these mixer elements _seem_ to interactive with each other, and cannot be controlled individually. That's why ENABLE_SB_MIXER is disabled. I cannot check this issue any longer since the test board got broken long time ago... I don't think we would get many gain by changing this old code. (and the relevant part isn't so big.) Let's keep as it is. Takashi