From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1757716AbWKXNCJ@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757716AbWKXNCJ (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 24 Nov 2006 08:02:09 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757720AbWKXNCJ
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 24 Nov 2006 08:02:09 -0500
Received: from ns.suse.de ([195.135.220.2]:60906 "EHLO mx1.suse.de")
	by vger.kernel.org with ESMTP id S1757716AbWKXNCI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 24 Nov 2006 08:02:08 -0500
Date: Fri, 24 Nov 2006 14:02:06 +0100
Message-ID: <s5hac2hf169.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Tony Lindgren <tony@atomide.com>,
       kernel list <linux-kernel@vger.kernel.org>,
       Vladimir Ananiev <vovan888@gmail.com>,
       linux-omap <linux-omap-open-source@linux.omap.com>
Subject: Re: sx1 mixer support
In-Reply-To: <20061124125040.GE5608@elf.ucw.cz>
References: <20061124111445.GA5940@elf.ucw.cz>
	<s5hk61lf4w3.wl%tiwai@suse.de>
	<20061124125040.GE5608@elf.ucw.cz>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27)
 (fiddleheads) (+CVS-20060704) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Fri, 24 Nov 2006 13:50:40 +0100,
Pavel Machek wrote:
> 
> > > + * Defines codec specific functions pointers that can be used from the
> > > + * common omap-alsa base driver for all omap codecs.
> > > + */
> > > +void egold_configure(void);
> > > +void egold_set_samplerate(long rate);
> > > +void egold_clock_setup(void);
> > > +int egold_clock_on(void);
> > > +int egold_clock_off(void);
> > > +int egold_get_default_samplerate(void);
> > 
> > Do they need to be exported?  I see them only in a single file as
> > callbacks...
> 
> Apparently they do not. Fixed.

They are still globals.  Could be static, right?


Takashi