From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932702AbVINK1K (ORCPT ); Wed, 14 Sep 2005 06:27:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932703AbVINK1K (ORCPT ); Wed, 14 Sep 2005 06:27:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:4307 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S932702AbVINK1J (ORCPT ); Wed, 14 Sep 2005 06:27:09 -0400 Date: Wed, 14 Sep 2005 12:27:07 +0200 Message-ID: From: Takashi Iwai To: Matthew Garrett Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [Alsa-devel] [PATCH] - allow multiple ac97 quirks for one piece of hardware In-Reply-To: <20050913145247.GA8422@srcf.ucam.org> References: <20050913145247.GA8422@srcf.ucam.org> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta18) (chestnut) (+CVS-20041021) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 13 Sep 2005 15:52:47 +0100, Matthew Garrett wrote: > > snd_ac97_tune_hardware currently exits after applying a single ac97 > quirk. There are bits of hardware (current HPs, for instance) that > probably want two - MUTE_LED and HP_ONLY. The following trivial patch > only exits if a quirk fails to apply. I'll send patches adding the > quirks when I've made sure they work as expected on these machines. Thanks, the patch looks OK (and Andrew already took it :) But how about a bit flag, AC97_TUNE_CONTINUE, to indicate to continue the quirk-parsing, instead of always continueing? Takashi