From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F84C388F7 for ; Tue, 10 Nov 2020 08:06:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E75532080A for ; Tue, 10 Nov 2020 08:06:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730302AbgKJIGd (ORCPT ); Tue, 10 Nov 2020 03:06:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:60770 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729382AbgKJIGc (ORCPT ); Tue, 10 Nov 2020 03:06:32 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B03F0ADFF; Tue, 10 Nov 2020 08:06:30 +0000 (UTC) Date: Tue, 10 Nov 2020 09:06:29 +0100 Message-ID: From: Takashi Iwai To: xiakaixu1987@gmail.com Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] ALSA: firewire: fix comparison to bool warning In-Reply-To: <1604765611-8209-1-git-send-email-kaixuxia@tencent.com> References: <1604765611-8209-1-git-send-email-kaixuxia@tencent.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 07 Nov 2020 17:13:31 +0100, xiakaixu1987@gmail.com wrote: > > From: Kaixu Xia > > Fix the following coccicheck warning: > > ./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool > > Reported-by: Tosk Robot > Signed-off-by: Kaixu Xia Thanks, applied. Takashi > --- > sound/firewire/amdtp-stream.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h > index 2ceb57d1d58e..a3daa1f2c1c4 100644 > --- a/sound/firewire/amdtp-stream.h > +++ b/sound/firewire/amdtp-stream.h > @@ -270,7 +270,7 @@ static inline bool amdtp_stream_wait_callback(struct amdtp_stream *s, > unsigned int timeout) > { > return wait_event_timeout(s->callback_wait, > - s->callbacked == true, > + s->callbacked, > msecs_to_jiffies(timeout)) > 0; > } > > -- > 2.20.0 >