From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753980AbcAZGDc (ORCPT ); Tue, 26 Jan 2016 01:03:32 -0500 Received: from mx2.suse.de ([195.135.220.15]:47829 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbcAZGDa (ORCPT ); Tue, 26 Jan 2016 01:03:30 -0500 Date: Tue, 26 Jan 2016 07:03:28 +0100 Message-ID: From: Takashi Iwai To: Lucas Tanure Cc: Clemens Ladisch , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ALSA: bebob: Use a signed return type for get_formation_index In-Reply-To: <1453757423-9076-1-git-send-email-tanure@linux.com> References: <1453757423-9076-1-git-send-email-tanure@linux.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jan 2016 22:30:23 +0100, Lucas Tanure wrote: > > The return type "unsigned int" was used by the get_formation_index function > despite of the aspect that it will eventually return a negative error code. > So, change to signed int and get index by reference in the parameters. > > Done with the help of Coccinelle. > > Signed-off-by: Lucas Tanure Applied, thanks. Takashi > --- > sound/firewire/bebob/bebob_stream.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/sound/firewire/bebob/bebob_stream.c b/sound/firewire/bebob/bebob_stream.c > index 926e5dc..79940e3 100644 > --- a/sound/firewire/bebob/bebob_stream.c > +++ b/sound/firewire/bebob/bebob_stream.c > @@ -47,14 +47,15 @@ static const unsigned int bridgeco_freq_table[] = { > [6] = 0x07, > }; > > -static unsigned int > -get_formation_index(unsigned int rate) > +static int > +get_formation_index(unsigned int rate, unsigned int *index) > { > unsigned int i; > > for (i = 0; i < ARRAY_SIZE(snd_bebob_rate_table); i++) { > if (snd_bebob_rate_table[i] == rate) > - return i; > + *index = i; > + return 0; > } > return -EINVAL; > } > @@ -425,7 +426,9 @@ make_both_connections(struct snd_bebob *bebob, unsigned int rate) > goto end; > > /* confirm params for both streams */ > - index = get_formation_index(rate); > + err = get_formation_index(rate, &index); > + if (err < 0) > + goto end; > pcm_channels = bebob->tx_stream_formations[index].pcm; > midi_channels = bebob->tx_stream_formations[index].midi; > err = amdtp_am824_set_parameters(&bebob->tx_stream, rate, > -- > 2.7.0 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >