From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753789AbbK3Kkp (ORCPT ); Mon, 30 Nov 2015 05:40:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:43997 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752182AbbK3Kkn (ORCPT ); Mon, 30 Nov 2015 05:40:43 -0500 Date: Mon, 30 Nov 2015 11:40:42 +0100 Message-ID: From: Takashi Iwai To: "Julia Lawall" Cc: "Jaroslav Kysela" , , , Subject: Re: [PATCH] ALSA: i2c: constify snd_i2c_ops structures In-Reply-To: <1448817924-17447-1-git-send-email-Julia.Lawall@lip6.fr> References: <1448817924-17447-1-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Nov 2015 18:25:24 +0100, Julia Lawall wrote: > > The snd_i2c_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Applied, thanks. Takashi > > --- > include/sound/i2c.h | 2 +- > sound/i2c/i2c.c | 2 +- > sound/pci/ice1712/delta.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/sound/i2c.h b/include/sound/i2c.h > index d125ff8..835254d 100644 > --- a/include/sound/i2c.h > +++ b/include/sound/i2c.h > @@ -66,7 +66,7 @@ struct snd_i2c_bus { > struct snd_i2c_bit_ops *bit; > void *ops; > } hw_ops; /* lowlevel operations */ > - struct snd_i2c_ops *ops; /* midlevel operations */ > + const struct snd_i2c_ops *ops; /* midlevel operations */ > > unsigned long private_value; > void *private_data; > diff --git a/sound/i2c/i2c.c b/sound/i2c/i2c.c > index 4677037..ef2a9af 100644 > --- a/sound/i2c/i2c.c > +++ b/sound/i2c/i2c.c > @@ -39,7 +39,7 @@ static int snd_i2c_bit_readbytes(struct snd_i2c_device *device, > static int snd_i2c_bit_probeaddr(struct snd_i2c_bus *bus, > unsigned short addr); > > -static struct snd_i2c_ops snd_i2c_bit_ops = { > +static const struct snd_i2c_ops snd_i2c_bit_ops = { > .sendbytes = snd_i2c_bit_sendbytes, > .readbytes = snd_i2c_bit_readbytes, > .probeaddr = snd_i2c_bit_probeaddr, > diff --git a/sound/pci/ice1712/delta.c b/sound/pci/ice1712/delta.c > index 496dbd0..3bfdc78 100644 > --- a/sound/pci/ice1712/delta.c > +++ b/sound/pci/ice1712/delta.c > @@ -174,7 +174,7 @@ static int ap_cs8427_probeaddr(struct snd_i2c_bus *bus, unsigned short addr) > return -ENOENT; > } > > -static struct snd_i2c_ops ap_cs8427_i2c_ops = { > +static const struct snd_i2c_ops ap_cs8427_i2c_ops = { > .sendbytes = ap_cs8427_sendbytes, > .readbytes = ap_cs8427_readbytes, > .probeaddr = ap_cs8427_probeaddr, > >