From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751948AbaKCJm1 (ORCPT ); Mon, 3 Nov 2014 04:42:27 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44436 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbaKCJm0 (ORCPT ); Mon, 3 Nov 2014 04:42:26 -0500 Date: Mon, 03 Nov 2014 10:42:24 +0100 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ALSA: echoaudio: remove all snd_printk In-Reply-To: <1415004383-1515-2-git-send-email-sudipm.mukherjee@gmail.com> References: <1415004383-1515-1-git-send-email-sudipm.mukherjee@gmail.com> <1415004383-1515-2-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 3 Nov 2014 14:16:23 +0530, Sudip Mukherjee wrote: > > @@ -98,7 +99,7 @@ static int init_hw(struct echoaudio *chip, u16 device_id, u16 subdevice_id) > ECHOCAPS_HAS_DIGITAL_MODE_SPDIF_OPTICAL | > ECHOCAPS_HAS_DIGITAL_MODE_ADAT; > > - DE_INIT(("init_hw done\n")); > + dev_info(chip->card->dev, "init_hw done\n"); This (and the rest of all dev_info() in your patch) should be dev_dbg(). They are no really useful information to be shown at each time the module is loaded. ("init_hw done"? Yeah, why not, when the module is loaded successfully :) thanks, Takashi