From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932746AbaHYODN (ORCPT ); Mon, 25 Aug 2014 10:03:13 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51367 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932613AbaHYODM (ORCPT ); Mon, 25 Aug 2014 10:03:12 -0400 Date: Mon, 25 Aug 2014 16:03:11 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: pci: ctxfi: ctpcm.c: printk replacement In-Reply-To: <1408973692-22742-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1408973692-22742-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 25 Aug 2014 19:04:52 +0530, Sudip Mukherjee wrote: > > replaced printk with corresponding pr_err > > Signed-off-by: Sudip Mukherjee Applied, thanks. Takashi > --- > sound/pci/ctxfi/ctpcm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/pci/ctxfi/ctpcm.c b/sound/pci/ctxfi/ctpcm.c > index e8a4feb..6826c2c 100644 > --- a/sound/pci/ctxfi/ctpcm.c > +++ b/sound/pci/ctxfi/ctpcm.c > @@ -217,7 +217,7 @@ static int ct_pcm_playback_prepare(struct snd_pcm_substream *substream) > err = atc->pcm_playback_prepare(atc, apcm); > > if (err < 0) { > - printk(KERN_ERR "ctxfi: Preparing pcm playback failed!!!\n"); > + pr_err("ctxfi: Preparing pcm playback failed!!!\n"); > return err; > } > > @@ -324,7 +324,7 @@ static int ct_pcm_capture_prepare(struct snd_pcm_substream *substream) > > err = atc->pcm_capture_prepare(atc, apcm); > if (err < 0) { > - printk(KERN_ERR "ctxfi: Preparing pcm capture failed!!!\n"); > + pr_err("ctxfi: Preparing pcm capture failed!!!\n"); > return err; > } > > @@ -435,7 +435,7 @@ int ct_alsa_pcm_create(struct ct_atc *atc, > err = snd_pcm_new(atc->card, "ctxfi", device, > playback_count, capture_count, &pcm); > if (err < 0) { > - printk(KERN_ERR "ctxfi: snd_pcm_new failed!! Err=%d\n", err); > + pr_err("ctxfi: snd_pcm_new failed!! Err=%d\n", err); > return err; > } > > -- > 1.8.1.2 >