From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754096Ab2KELiq (ORCPT <rfc822;w@1wt.eu>);
	Mon, 5 Nov 2012 06:38:46 -0500
Received: from cantor2.suse.de ([195.135.220.15]:46364 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753374Ab2KELio (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 5 Nov 2012 06:38:44 -0500
Date: Mon, 05 Nov 2012 12:38:43 +0100
Message-ID: <s5hbofc9t4s.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Daniel J Blueman <daniel@quora.org>
Cc: alsa-devel@alsa-project.org,
        Alexander Stein <alexander.stein@systec-electronic.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] HDA: Fix digital microphone on CS420x
In-Reply-To: <CAMVG2sv2dD=WXAiJnpEO7e-pnJ5gOnCn0JK5P+B_SWc4Wqg36w@mail.gmail.com>
References: <1352006344-3378-1-git-send-email-daniel@quora.org>
	<s5hd2ztsryr.wl%tiwai@suse.de>
	<CAMVG2sv2dD=WXAiJnpEO7e-pnJ5gOnCn0JK5P+B_SWc4Wqg36w@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon, 5 Nov 2012 07:22:24 +0800,
Daniel J Blueman wrote:
> 
> [1  <text/plain; ISO-8859-1 (7bit)>]
> On 4 November 2012 16:16, Takashi Iwai <tiwai@suse.de> wrote:
> 
> > At Sun,  4 Nov 2012 13:19:03 +0800,
> > Daniel J Blueman wrote:
> > >
> > > Correctly enable the digital microphones with the right bits in the
> > right coeffecient
> > > registers on Cirrus CS4206/7 codecs. It also prevents misconfiguring
> > ADC1/2.
> > >
> > > This fixes the digital mic on the Macbook Pro 10,1/Retina.
> > >
> > > Based-on-patch-by: Alexander Stein <
> > alexander.stein@systec-electronic.com>
> > > Signed-off-by: Daniel J Blueman <daniel@quora.org>
> >
> > Thanks, this looks more comprehensive.  DIG1 and DIG2 seem to have
> > been set wrongly in the original code, based on the Cirrus's example
> > code.  Is the right-only recording problem fixed by this patch?
> >
> 
> It is fixed. In the mbp101 init verbs, setting the vendor widget ADC
> configuration bit 12 to copy the ADC2 right channel to the left (0x1004 to
> nid 0x11 coef 2) is superfluous here, so presumably for the analogue mic
> in. I'll get time later to check all this.
> 
> The second coefficient index initialisation (0x000f to nid 0x11 coef 4) is
> now redundant, as we enable the mic bits later correctly now. I'll send an
> updated patch which drops this.

OK, I applied fix patches now to sound git tree for-linus branch,
queued for 3.7-rc5.

Feel free to work on further clean ups.


thanks,

Takashi