mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Ondrej Zary <linux@rainbow-software.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 3/4] Add Wolfson Microelectronics WM8776 codec ALSA driver
Date: Tue, 17 Apr 2012 18:52:49 +0200	[thread overview]
Message-ID: <s5hbomqpafy.wl%tiwai@suse.de> (raw)
In-Reply-To: <20120417165005.GR6652@opensource.wolfsonmicro.com>

At Tue, 17 Apr 2012 17:50:06 +0100,
Mark Brown wrote:
> 
> On Tue, Apr 17, 2012 at 06:32:18PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > What makes you cleaim that "ASoC was not designed to be used with sound
> > > cards"?  Implementing sound cards is the sole purpose of ASoC...
> 
> > You don't need to overreact, he surely means only about the existing
> > ice1724 sound driver for his device :)
> 
> Possibly...  it's really not clear.
> 
> > Restructuring ice1712 and ice1724 drivers to use ASoC would require
> > quite a lot of works, and no one really wants it, I guess.  Many
> > boards are old and can't be tested easily.  And, we still need to
> > match the ASoC components with the controls of the current driver.
> 
> > This was already discussed a bit, and Clemens suggested like this
> > way.
> 
> This isn't just adding something into a specific driver which fails at
> abstraction, it's adding generic code.  If it were adding something to
> the ice17xx driver then that'd be one thing but look at the subject line
> and location of the file...  this stuff should be buried inside the
> driver if it's too painful to make the driver sane.

The codes in sound/i2c are mostly oly for ice1712/ice1724 drivers
after all...  They could be used by others, but I don't think there
will be any more at this point.


Takashi

  reply	other threads:[~2012-04-17 16:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16 21:18 [RFC PATCH 0/4] snd-ice1712: Add Philips PSC724 Ultimate Edge Ondrej Zary
2012-04-16 21:18 ` [PATCH 1/4] snd-ice1712: add chip_exit callback Ondrej Zary
2012-04-16 21:18 ` [PATCH 2/4] Add Wolfson Microelectronics WM8766 codec ALSA driver Ondrej Zary
2012-04-17 14:59   ` Mark Brown
2012-04-17 16:35     ` Ondrej Zary
2012-04-17 16:54       ` Mark Brown
2012-04-16 21:18 ` [PATCH 3/4] Add Wolfson Microelectronics WM8776 " Ondrej Zary
2012-04-17 15:02   ` Mark Brown
2012-04-17 16:13     ` Ondrej Zary
2012-04-17 16:18       ` Mark Brown
2012-04-17 16:32         ` [alsa-devel] " Takashi Iwai
2012-04-17 16:50           ` Mark Brown
2012-04-17 16:52             ` Takashi Iwai [this message]
2012-04-17 17:04               ` Mark Brown
2012-04-17 18:06                 ` Takashi Iwai
2012-04-17 18:15                   ` Ondrej Zary
2012-04-17 18:22                     ` Mark Brown
2012-04-17 19:14                       ` Takashi Iwai
2012-04-17 19:43                         ` Mark Brown
2012-04-17 19:12                     ` Takashi Iwai
2012-04-17 21:07                       ` Ondrej Zary
2012-04-18  5:54                         ` Takashi Iwai
2012-04-18  6:52                           ` Clemens Ladisch
2012-04-16 21:18 ` [PATCH 4/4] snd-ice1712: Add Philips PSC724 Ultimate Edge Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hbomqpafy.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®