From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755907AbYHSJwr (ORCPT ); Tue, 19 Aug 2008 05:52:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751830AbYHSJwi (ORCPT ); Tue, 19 Aug 2008 05:52:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55418 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188AbYHSJwh (ORCPT ); Tue, 19 Aug 2008 05:52:37 -0400 Date: Tue, 19 Aug 2008 11:52:34 +0200 Message-ID: From: Takashi Iwai To: "Johannes Berg" Cc: "roel kluin" , linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] duplicate SNDRV_PCM_FMTBIT_S{16,24}_BE In-Reply-To: <3ef3fed769e5aa57681bacea1230e82b.squirrel@secure.sipsolutions.net> References: <48AA407C.8090409@gmail.com> <3ef3fed769e5aa57681bacea1230e82b.squirrel@secure.sipsolutions.net> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 19 Aug 2008 08:15:05 +0200 (CEST), Johannes Berg wrote: > > roel kluin wrote: > > untested, is it correct? > > not a clue, do you know how long ago that was? :) > does the driver check endianness anywhere? AFAIK snd-aoa supports only bit-endian formats (at least in sound/aoa/soundbus/i2sbus-pcm.c), so this addition makes little sense. Better to drop the duplicated words there. thanks, Takashi > > duplicate SNDRV_PCM_FMTBIT_S{16,24}_BE > > > > Signed-off-by: Roel Kluin > > --- > > diff --git a/sound/aoa/codecs/snd-aoa-codec-tas.c > > b/sound/aoa/codecs/snd-aoa-codec-tas.c > > index 7a16a33..c922505 100644 > > --- a/sound/aoa/codecs/snd-aoa-codec-tas.c > > +++ b/sound/aoa/codecs/snd-aoa-codec-tas.c > > @@ -654,15 +654,15 @@ static struct snd_kcontrol_new bass_control = { > > static struct transfer_info tas_transfers[] = { > > { > > /* input */ > > - .formats = SNDRV_PCM_FMTBIT_S16_BE | SNDRV_PCM_FMTBIT_S16_BE | > > - SNDRV_PCM_FMTBIT_S24_BE | SNDRV_PCM_FMTBIT_S24_BE, > > + .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE | > > + SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S24_BE, > > .rates = SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 | > > SNDRV_PCM_RATE_48000, > > .transfer_in = 1, > > }, > > { > > /* output */ > > - .formats = SNDRV_PCM_FMTBIT_S16_BE | SNDRV_PCM_FMTBIT_S16_BE | > > - SNDRV_PCM_FMTBIT_S24_BE | SNDRV_PCM_FMTBIT_S24_BE, > > + .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE | > > + SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S24_BE, > > .rates = SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 | > > SNDRV_PCM_RATE_48000, > > .transfer_in = 0, > > }, > > > > > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >