From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbYGDSt5 (ORCPT ); Fri, 4 Jul 2008 14:49:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750839AbYGDSts (ORCPT ); Fri, 4 Jul 2008 14:49:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:35007 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721AbYGDStr (ORCPT ); Fri, 4 Jul 2008 14:49:47 -0400 Date: Fri, 04 Jul 2008 20:49:44 +0200 Message-ID: From: Takashi Iwai To: Lennert Buytenhek Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML Subject: Re: [PATCH next-20080704] Fix compile error in drivers/net/mv643xx_eth.c In-Reply-To: <20080704164954.GA12106@xi.wantstofly.org> References: <20080704164954.GA12106@xi.wantstofly.org> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (x86_64-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 4 Jul 2008 18:49:55 +0200, Lennert Buytenhek wrote: > > On Fri, Jul 04, 2008 at 06:32:03PM +0200, Takashi Iwai wrote: > > > drivers/net/mv643xx_eth.c: In function 'mv643xx_eth_netpoll': > > drivers/net/mv643xx_eth.c:2115: error: 'INT_CAUSE_EXT' undeclared (first use in this function) > > drivers/net/mv643xx_eth.c:2115: error: (Each undeclared identifier is reported only once > > drivers/net/mv643xx_eth.c:2115: error: for each function it appears in. > > > > Signed-off-by: Takashi Iwai > > > > --- > > diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c > > index 83a877f..cb2c065 100644 > > --- a/drivers/net/mv643xx_eth.c > > +++ b/drivers/net/mv643xx_eth.c > > @@ -2112,7 +2112,8 @@ static void mv643xx_eth_netpoll(struct net_device *dev) > > > > mv643xx_eth_irq(dev->irq, dev); > > > > - wrl(mp, INT_MASK(mp->port_num), INT_TX_END | INT_RX | INT_CAUSE_EXT); > > + wrl(mp, INT_MASK(mp->port_num), > > + INT_TX_END | INT_RX | INT_CAUSE_EXT(mp->port_num)); > > You are ORing the _address_ of the interrupt status register into > the interupt mask register. How do you expect that to work? > > This is the proper fix, which I will re-submit shortly: > > http://marc.info/?l=linux-kernel&m=121498695309851&w=2 Just my ignorance, disregard my broken patch. But why the heck is this still hanging for so long time? The linux-next tree is built everyday, and why such an obvious fix isn't picked up...? thanks, Takashi