From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934278AbYDQQKQ (ORCPT ); Thu, 17 Apr 2008 12:10:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765917AbYDQQJy (ORCPT ); Thu, 17 Apr 2008 12:09:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:43036 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933802AbYDQQJx (ORCPT ); Thu, 17 Apr 2008 12:09:53 -0400 Date: Thu, 17 Apr 2008 18:09:51 +0200 Message-ID: From: Takashi Iwai To: Roel Kluin <12o3l@tiscali.nl> Cc: liam.girdwood@wolfsonmicro.com, broonie@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, lkml Subject: Re: [alsa-devel] [PATCH] SOC: fix tests in cs4270_hw_params() In-Reply-To: <480770A3.3070805@tiscali.nl> References: <480770A3.3070805@tiscali.nl> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 17 Apr 2008 17:45:39 +0200, Roel Kluin wrote: > > cs4270_hw_params does several times: > > ret = snd_soc_write() > if (ret < 0) > ... > > This only works when ret is signed. > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Applied to ALSA tree. Thanks. Takashi > --- > diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c > index bf2ab72..e73fcfd 100644 > --- a/sound/soc/codecs/cs4270.c > +++ b/sound/soc/codecs/cs4270.c > @@ -372,7 +372,7 @@ static int cs4270_hw_params(struct snd_pcm_substream *substream, > struct snd_soc_device *socdev = rtd->socdev; > struct snd_soc_codec *codec = socdev->codec; > struct cs4270_private *cs4270 = codec->private_data; > - unsigned int ret = 0; > + int ret; > unsigned int i; > unsigned int rate; > unsigned int ratio; > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >