From: Takashi Iwai <tiwai@suse.de>
To: Eugene Teo <eugene.teo@eugeneteo.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Fix ali5451 dereferenced before NULL check
Date: Thu, 16 Mar 2006 12:08:24 +0100 [thread overview]
Message-ID: <s5hbqw6r6jb.wl%tiwai@suse.de> (raw)
In-Reply-To: <20060316013602.GA20455@eugeneteo.net>
At Thu, 16 Mar 2006 09:36:02 +0800,
Eugene Teo wrote:
>
> pvoice is missing a NULL check. channel needs a bound check too.
Both checks are not necessary. There is a single caller to this
function, and the channel argument is a loop value of
for (channel = 0; channel < ALI_CHANNELS; channel++)
snd_ali_update_ptr(codec, channel);
pvoice is the address pointing a part of a structure, so it cannot be
NULL anyway. If a check were needed, it should be if (codec != NULL).
Takashi
>
> Coverity bug #862
>
> Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
>
> --- linux-2.6/sound/pci/ali5451/ali5451.c~ 2006-03-15 10:05:45.000000000 +0800
> +++ linux-2.6/sound/pci/ali5451/ali5451.c 2006-03-16 09:27:53.000000000 +0800
> @@ -990,7 +990,13 @@
> if (!(old & mask))
> return;
>
> + if (channel < 0 || channel >= ALI_CHANNELS)
> + return;
> +
> pvoice = &codec->synth.voices[channel];
> + if (pvoice == NULL)
> + return;
> +
> runtime = pvoice->substream->runtime;
>
> udelay(100);
>
> --
> 1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80
> main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2006-03-16 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 1:36 Eugene Teo
2006-03-16 11:08 ` Takashi Iwai [this message]
2006-03-16 11:48 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbqw6r6jb.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=eugene.teo@eugeneteo.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®