From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55741C07E95 for ; Wed, 7 Jul 2021 11:26:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E60661CC4 for ; Wed, 7 Jul 2021 11:26:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231417AbhGGL3V (ORCPT ); Wed, 7 Jul 2021 07:29:21 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:45862 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231397AbhGGL3U (ORCPT ); Wed, 7 Jul 2021 07:29:20 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 4705220072; Wed, 7 Jul 2021 11:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625657199; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QQRXUK1aEBmgQ+aYoruFRQe9bnybrkyuCJq1exn177c=; b=SsMk2tYuHtdG7YTovzn2kfpzYpprXT12zjbs7m/lNAOe/SOJNcW2RVQkNey2dwE022lkw/ JYqvOrBcp5f5/jTAOke+OPzCx2mkE/3sCrI71rcWSd2C6FbizaCHAEUfq5pkfUtMVGndIq MzwIMOdiWVsTlCBJ2ADdBFpT4WNUc8Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625657199; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QQRXUK1aEBmgQ+aYoruFRQe9bnybrkyuCJq1exn177c=; b=BtrElN9df9W4iwk7c/OuRI3VQBq3vMLBzOGfxeXLl0JxlUMDPJ5osLiv2TU8z9pfEH/6/X JcNa+7iFWtbAInBg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 3222FA3B8A; Wed, 7 Jul 2021 11:26:39 +0000 (UTC) Date: Wed, 07 Jul 2021 13:26:39 +0200 Message-ID: From: Takashi Iwai To: Zhen Lei Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel , linux-kernel Subject: Re: [PATCH 1/1] ALSA: isa: Fix error return code in snd_cmi8330_probe() In-Reply-To: <20210707074051.2663-1-thunder.leizhen@huawei.com> References: <20210707074051.2663-1-thunder.leizhen@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 07 Jul 2021 09:40:51 +0200, Zhen Lei wrote: > > When 'SB_HW_16' check fails, the error code -ENODEV instead of 0 should be > returned, which is the same as that returned when 'WSS_HW_CMI8330' check > fails. > > Fixes: 43bcd973d6d0 ("[ALSA] Add snd_card_set_generic_dev() call to ISA drivers") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei Thanks, applied. Takashi