From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8024BC34021 for ; Mon, 17 Feb 2020 14:18:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54346207FD for ; Mon, 17 Feb 2020 14:18:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728571AbgBQOSj (ORCPT ); Mon, 17 Feb 2020 09:18:39 -0500 Received: from mx2.suse.de ([195.135.220.15]:53052 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbgBQOSg (ORCPT ); Mon, 17 Feb 2020 09:18:36 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0757FB3D8; Mon, 17 Feb 2020 14:18:35 +0000 (UTC) Date: Mon, 17 Feb 2020 15:18:34 +0100 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] usb: audio-v2: Add uac2_effect_unit_descriptor definition In-Reply-To: <20200213112059.18745-2-tiwai@suse.de> References: <20200213112059.18745-1-tiwai@suse.de> <20200213112059.18745-2-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Feb 2020 12:20:58 +0100, Takashi Iwai wrote: > > The UAC2 Effect Unit Descriptor has a slightly different definition > from other similar ones like Processing Unit or Extension Unit. > Define it here so that it can be used in USB-audio driver in a later > patch. > > Signed-off-by: Takashi Iwai > --- > include/linux/usb/audio-v2.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/linux/usb/audio-v2.h b/include/linux/usb/audio-v2.h > index ba4b3e3327ff..cb9900b34b67 100644 > --- a/include/linux/usb/audio-v2.h > +++ b/include/linux/usb/audio-v2.h > @@ -156,6 +156,18 @@ struct uac2_feature_unit_descriptor { > __u8 bmaControls[0]; /* variable length */ > } __attribute__((packed)); > > +/* 4.7.2.10 Effect Unit Descriptor */ > + > +struct uac2_effect_unit_descriptor { > + __u8 bLength; > + __u8 bDescriptorType; > + __u8 bDescriptorSubtype; > + __u8 bUnitID; > + __le16 wEffectType; > + __u8 bSourceID; > + __u8 bmaControls[]; /* variable length */ > +} __attribute__((packed)); > + > /* 4.9.2 Class-Specific AS Interface Descriptor */ > > struct uac2_as_header_descriptor { Greg, I suppose you are OK with this addition? thanks, Takashi