From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C87AC433FF for ; Tue, 30 Jul 2019 07:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48C0E206E0 for ; Tue, 30 Jul 2019 07:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730601AbfG3HjE (ORCPT ); Tue, 30 Jul 2019 03:39:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:56544 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729497AbfG3HjD (ORCPT ); Tue, 30 Jul 2019 03:39:03 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C4B2EAD17; Tue, 30 Jul 2019 07:39:02 +0000 (UTC) Date: Tue, 30 Jul 2019 09:39:02 +0200 Message-ID: From: Takashi Iwai To: " Gustavo A. R. Silva " Cc: "Jaroslav Kysela" , , "Kees Cook" , Subject: Re: [PATCH] ALSA: sparc: Mark expected switch fall-throughs In-Reply-To: <20190730014944.GA31900@embeddedor> References: <20190730014944.GA31900@embeddedor> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Jul 2019 03:49:44 +0200, Gustavo A. R. Silva wrote: > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings (Building: sparc64): > > sound/sparc/dbri.c: In function ‘reverse_bytes’: > sound/sparc/dbri.c:582:5: warning: this statement may fall through [-Wimplicit-fallthrough=] > b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16); > ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sound/sparc/dbri.c:583:2: note: here > case 16: > ^~~~ > sound/sparc/dbri.c:584:5: warning: this statement may fall through [-Wimplicit-fallthrough=] > b = ((b & 0xff00ff00) >> 8) | ((b & 0x00ff00ff) << 8); > ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sound/sparc/dbri.c:585:2: note: here > case 8: > ^~~~ > sound/sparc/dbri.c:586:5: warning: this statement may fall through [-Wimplicit-fallthrough=] > b = ((b & 0xf0f0f0f0) >> 4) | ((b & 0x0f0f0f0f) << 4); > ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sound/sparc/dbri.c:587:2: note: here > case 4: > ^~~~ > sound/sparc/dbri.c:588:5: warning: this statement may fall through [-Wimplicit-fallthrough=] > b = ((b & 0xcccccccc) >> 2) | ((b & 0x33333333) << 2); > ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sound/sparc/dbri.c:589:2: note: here > case 2: > ^~~~ > > Signed-off-by: Gustavo A. R. Silva Applied, thanks. Takashi