From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F915C43219 for ; Sun, 28 Apr 2019 07:18:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71EFF21473 for ; Sun, 28 Apr 2019 07:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726560AbfD1HSm (ORCPT ); Sun, 28 Apr 2019 03:18:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:39842 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726133AbfD1HSl (ORCPT ); Sun, 28 Apr 2019 03:18:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A161BAEBC; Sun, 28 Apr 2019 07:18:40 +0000 (UTC) Date: Sun, 28 Apr 2019 09:18:40 +0200 Message-ID: From: Takashi Iwai To: "Wenwen Wang" Cc: "moderated list:SOUND" , "Kees Cook" , "Jaroslav Kysela" , "open list" Subject: Re: [PATCH] ALSA: usx2y: fix a memory leak bug In-Reply-To: <1556433754-3291-1-git-send-email-wang6495@umn.edu> References: <1556433754-3291-1-git-send-email-wang6495@umn.edu> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 28 Apr 2019 08:42:32 +0200, Wenwen Wang wrote: > > In usX2Y_In04_init(), a new urb is firstly created through usb_alloc_urb() > and saved to 'usX2Y->In04urb'. Then, a buffer is allocated through > kmalloc() and saved to 'usX2Y->In04Buf'. After the urb is initialized, a > sanity check is performed for the endpoint in the urb by invoking > usb_urb_ep_type_check(). If the check fails, the error code EINVAL will be > returned. In that case, however, the created urb and the allocated buffer > are not freed, leading to memory leaks. > > To fix the above issue, free the urb and the buffer if the check fails. > > Signed-off-by: Wenwen Wang Applied now, thanks. Takashi