From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752307AbdK1Hbo (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 02:31:44 -0500
Received: from mx2.suse.de ([195.135.220.15]:60549 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751256AbdK1Hbl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 02:31:41 -0500
Date: Tue, 28 Nov 2017 08:31:39 +0100
Message-ID: <s5hd142luzo.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "SF Markus Elfring" <elfring@users.sourceforge.net>
Cc: <alsa-devel@alsa-project.org>, "Kees Cook" <keescook@chromium.org>,
        "Alexey Dobriyan" <adobriyan@gmail.com>,
        "Bhumika Goyal" <bhumirks@gmail.com>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        "Jaroslav Kysela" <perex@perex.cz>, <kernel-janitors@vger.kernel.org>,
        "LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] ALSA: korg1212: Delete a duplicate function call "release_firmware" in snd_korg1212_create()
In-Reply-To: <7b5b034c-e441-f363-a94f-c81bd0b5ed7a@users.sourceforge.net>
References: <3f68211d-51f0-2990-d711-44eaeb85ba4d@users.sourceforge.net>
        <7b5b034c-e441-f363-a94f-c81bd0b5ed7a@users.sourceforge.net>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 16 Nov 2017 12:52:41 +0100,
SF Markus Elfring wrote:
> 
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 16 Nov 2017 11:22:26 +0100
> 
> The function "release_firmware" is called in the current implementation of
> the function "_request_firmware" after a failure was detected.
> Link: https://elixir.free-electrons.com/linux/v4.14-rc8/source/drivers/base/firmware_class.c#L1196
> 
> Such a call should therefore not be repeated directly after the
> corresponding error information was received in the local variable "err"
> of the function "snd_korg1212_create".
> Thus remove a misplaced function call.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Applied, thanks.


Takashi