From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943458AbdDTKvX (ORCPT ); Thu, 20 Apr 2017 06:51:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:38546 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S943268AbdDTKvR (ORCPT ); Thu, 20 Apr 2017 06:51:17 -0400 Date: Thu, 20 Apr 2017 12:51:15 +0200 Message-ID: From: Takashi Iwai To: "Arnd Bergmann" Cc: "Clemens Ladisch" , "Jaroslav Kysela" , , "Takashi Sakamoto" , Subject: Re: [PATCH] ALSA: firewire-motu: mark trace helpers as __maybe_unused In-Reply-To: <20170419175158.5607-1-arnd@arndb.de> References: <20170419175158.5607-1-arnd@arndb.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Apr 2017 19:51:29 +0200, Arnd Bergmann wrote: > > Two functions were introduced for the purpose of tracing but cause warnings > when tracing is disabled: > > sound/firewire/motu/amdtp-motu.c:284:13: error: 'copy_message' defined but not used [-Werror=unused-function] > static void copy_message(u64 *frames, __be32 *buffer, unsigned int data_blocks, > sound/firewire/motu/amdtp-motu.c:271:13: error: 'copy_sph' defined but not used [-Werror=unused-function] > static void copy_sph(u32 *frames, __be32 *buffer, unsigned int data_blocks, > > Marking them as __maybe_unused will do the right thing here. > > Fixes: 17909c1b3058 ("ALSA: firewire-motu: add tracepoints for SPH in IEC 61883-1 fashion") > Fixes: c6b0b9e65f09 ("ALSA: firewire-motu: add tracepoints for messages for unique protocol") > Signed-off-by: Arnd Bergmann Applied, thanks. Takashi