From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754588AbdCTLYv (ORCPT ); Mon, 20 Mar 2017 07:24:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:43900 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754313AbdCTLYs (ORCPT ); Mon, 20 Mar 2017 07:24:48 -0400 Date: Mon, 20 Mar 2017 12:24:45 +0100 Message-ID: From: Takashi Iwai To: Nicolas Iooss Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 1/1] ALSA: es1688: Use strcpy() instead of sprintf() In-Reply-To: <20170313192250.23497-1-nicolas.iooss_linux@m4x.org> References: <20170313192250.23497-1-nicolas.iooss_linux@m4x.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Mar 2017 20:22:50 +0100, Nicolas Iooss wrote: > > There is no point in using sprintf() without a format string when > strcpy() can perform the same operation. > > Signed-off-by: Nicolas Iooss Applied, thanks. Takashi > --- > sound/isa/es1688/es1688_lib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/isa/es1688/es1688_lib.c b/sound/isa/es1688/es1688_lib.c > index e2cf508841b1..81cf26fa28d6 100644 > --- a/sound/isa/es1688/es1688_lib.c > +++ b/sound/isa/es1688/es1688_lib.c > @@ -742,7 +742,7 @@ int snd_es1688_pcm(struct snd_card *card, struct snd_es1688 *chip, int device) > > pcm->private_data = chip; > pcm->info_flags = SNDRV_PCM_INFO_HALF_DUPLEX; > - sprintf(pcm->name, snd_es1688_chip_id(chip)); > + strcpy(pcm->name, snd_es1688_chip_id(chip)); > chip->pcm = pcm; > > snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV, > -- > 2.12.0 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >