From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756000AbcEQQDI (ORCPT ); Tue, 17 May 2016 12:03:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:37103 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752803AbcEQQDF (ORCPT ); Tue, 17 May 2016 12:03:05 -0400 Date: Tue, 17 May 2016 18:03:01 +0200 Message-ID: From: Takashi Iwai To: "Muhammad Falak R Wani" Cc: , "Jaroslav Kysela" , Subject: Re: [PATCH] sound: oss: Use setup_timer and mod_timer. In-Reply-To: <1463309821-10911-1-git-send-email-falakreyaz@gmail.com> References: <1463309821-10911-1-git-send-email-falakreyaz@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 15 May 2016 12:56:51 +0200, Muhammad Falak R Wani wrote: > > The function setup_timer combines the initialization of a timer with the > initialization of the timer's function and data fields. The mulitiline > code for timer initialization is now replaced with function setup_timer. > > Also, quoting the mod_timer() function comment: > -> mod_timer() is a more efficient way to update the expire field of an > active timer (if the timer is inactive it will be activated). > > Use setup_timer() and mod_timer() to setup and arm a timer, making the > code compact and aid readablity. > > Signed-off-by: Muhammad Falak R Wani Applied, thanks. Takashi