From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753734AbaHEMhU (ORCPT ); Tue, 5 Aug 2014 08:37:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48232 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753507AbaHEMhT (ORCPT ); Tue, 5 Aug 2014 08:37:19 -0400 Date: Tue, 05 Aug 2014 14:37:17 +0200 Message-ID: From: Takashi Iwai To: Himangi Saraogi Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] sound/oss/opl3: Remove typedef opl_devinfo In-Reply-To: <20140805120718.GA12767@himangi-Dell> References: <20140805120718.GA12767@himangi-Dell> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 5 Aug 2014 17:37:18 +0530, Himangi Saraogi wrote: > > This typedef is unnecessary and should just be removed as they are > never used. > > The following Coccinelle semantic patch detects the case. > > @tn@ > identifier i; > type td; > @@ > > -typedef > struct i { ... } > -td > ; > > @@ > type tn.td; > identifier tn.i; > @@ > > -td > + struct i > > Signed-off-by: Himangi Saraogi > Acked-by: Julia Lawall Applied, thanks. Takashi > --- > sound/oss/opl3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/oss/opl3.c b/sound/oss/opl3.c > index 4709e59..607cee4 100644 > --- a/sound/oss/opl3.c > +++ b/sound/oss/opl3.c > @@ -52,7 +52,7 @@ struct voice_info > int panning; /* 0xffff means not set */ > }; > > -typedef struct opl_devinfo > +struct opl_devinfo > { > int base; > int left_io, right_io; > @@ -73,7 +73,7 @@ typedef struct opl_devinfo > unsigned char cmask; > > int is_opl4; > -} opl_devinfo; > +}; > > static struct opl_devinfo *devc = NULL; > > -- > 1.9.1 > 1