From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751709AbaHDJRs (ORCPT ); Mon, 4 Aug 2014 05:17:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55292 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751324AbaHDJRq (ORCPT ); Mon, 4 Aug 2014 05:17:46 -0400 Date: Mon, 04 Aug 2014 11:17:45 +0200 Message-ID: From: Takashi Iwai To: paul Cc: perex@perex.cz, linux-kernel@vger.kernel.org Subject: Re: PATCH Gamecom 780 volume level (resubmit) kernel 3.15 In-Reply-To: <53DEBC08.1040600@gmail.com> References: <53DEB837.6020006@mcspadden.net> <53DEBC08.1040600@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 03 Aug 2014 17:47:36 -0500, paul wrote: > > Original patch fixed the original problem, but the sound was far too low > for most users. This patch references a compare matrix to allow the > volume levels to act normally. I personally tested this patch myself, > and volume levels returned to normal. Please see this discussion for > more details: https://bugzilla.kernel.org/show_bug.cgi?id=65251 > > Patch notes: Fixed low volume levels of the Gamecom 780 starting with > the 3.14 kernel. > > Patch---------------------------------------------------------------------------- > > --- linux-3.15/sound/usb/quirks.c.orig 2014-06-08 13:19:54.000000000 -0500 > +++ linux-3.15/sound/usb/quirks.c 2014-08-03 14:42:03.000000000 -0500 > @@ -670,7 +670,7 @@ static int snd_usb_gamecon780_boot_quirk > /* set the initial volume and don't change; other values are either > * too loud or silent due to firmware bug (bko#65251) > */ > - u8 buf[2] = { 0x74, 0xdc }; > + u8 buf[2] = { 0x74, 0xe3 }; > return snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0), UAC_SET_CUR, > USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_OUT, > UAC_FU_VOLUME << 8, 9 << 8, buf, 2); > > > > Signed-off-by: Paul S McSpadden I applied the patch after manual adjustment now. But, at the next time, please submit the patch directly applicable. See Documentation/SubmittingPatches for details. thanks, Takashi