From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756036AbaFWQA6 (ORCPT ); Mon, 23 Jun 2014 12:00:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52254 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754060AbaFWQA5 (ORCPT ); Mon, 23 Jun 2014 12:00:57 -0400 Date: Mon, 23 Jun 2014 18:00:55 +0200 Message-ID: From: Takashi Iwai To: Rasmus Villemoes Cc: Jaroslav Kysela , Jiri Kosina , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] trivial: sound/core/seq/seq_memory.c: Fix closing brace followed by if In-Reply-To: <1403538969-26147-1-git-send-email-linux@rasmusvillemoes.dk> References: <1403293803-17650-1-git-send-email-linux@rasmusvillemoes.dk> <1403538969-26147-1-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 23 Jun 2014 17:56:09 +0200, Rasmus Villemoes wrote: > > Add a newline and, while at it, remove a space and redundant braces. > > Signed-off-by: Rasmus Villemoes Thanks, applied now. I usually don't take patches that only do coding style fixes unless any further real fixes follow, but this case looks like an exception: the placement of if is actually wrong so it's worth to correct (although the code could be "else if" there). Takashi > --- > sound/core/seq/seq_memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/core/seq/seq_memory.c b/sound/core/seq/seq_memory.c > index 1e206de..ba8e4a6 100644 > --- a/sound/core/seq/seq_memory.c > +++ b/sound/core/seq/seq_memory.c > @@ -101,9 +101,9 @@ int snd_seq_dump_var_event(const struct snd_seq_event *event, > len -= size; > } > return 0; > - } if (! (event->data.ext.len & SNDRV_SEQ_EXT_CHAINED)) { > - return func(private_data, event->data.ext.ptr, len); > } > + if (!(event->data.ext.len & SNDRV_SEQ_EXT_CHAINED)) > + return func(private_data, event->data.ext.ptr, len); > > cell = (struct snd_seq_event_cell *)event->data.ext.ptr; > for (; len > 0 && cell; cell = cell->next) { > -- > 1.9.2 >