From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755664Ab3A2J5G (ORCPT ); Tue, 29 Jan 2013 04:57:06 -0500 Received: from cantor2.suse.de ([195.135.220.15]:47214 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413Ab3A2J5B (ORCPT ); Tue, 29 Jan 2013 04:57:01 -0500 Date: Tue, 29 Jan 2013 10:57:00 +0100 Message-ID: From: Takashi Iwai To: Daniel Vetter Cc: David Airlie , dri-devel@lists.freedesktop.org, Bernhard Wiedemann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/cirrus: Add bpp option In-Reply-To: <20130129095350.GI14766@phenom.ffwll.local> References: <1359130915-30082-1-git-send-email-tiwai@suse.de> <1359130915-30082-2-git-send-email-tiwai@suse.de> <20130129095350.GI14766@phenom.ffwll.local> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 29 Jan 2013 10:53:50 +0100, Daniel Vetter wrote: > > On Tue, Jan 29, 2013 at 09:29:17AM +0100, Takashi Iwai wrote: > > Add a new option, bpp, to specify the default bpp value. > > > > Signed-off-by: Takashi Iwai > > --- > > > > This patch is applied on the top of previous two patches. > > I couldn't find an easy way to specify the default bpp, so I cooked > > the driver quickly. If there is any other convenient way to achieve > > this, let me know... > > Well, you can specify the desired bpp with a full mode on the kernel > cmdline - the '-bpp' extension. Reading through the parser I think it > should work even with just the '-bpp' and not a full mode, but I haven't > tested. Look for cmdline_mode->bpp_specified in drm_fb_helper.c and the > relevant parsing code in drm_mode_parse_command_line_for_connector in > drm_modes.c > > If that doesn't work for you, I think it's better to extend/fix it than > add driver module options. Well, the fb can be set by that option, but the default modeset doesn't seem to honor it. So if you start X modeset driver, it still takes what the driver sets as default. That was the problem I hit. thanks, Takashi