From: Takashi Iwai <tiwai@suse.de>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Liam Girdwood <lrg@ti.com>,
Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH] SOUND: Fix txx9aclc.c build
Date: Fri, 29 Jul 2011 07:55:36 +0200 [thread overview]
Message-ID: <s5hd3gt636v.wl%tiwai@suse.de> (raw)
In-Reply-To: <20110728112616.GA27918@linux-mips.org>
At Thu, 28 Jul 2011 12:26:16 +0100,
Ralf Baechle wrote:
>
> 552d1ef6b5a98d7b95959d5b139071e3c90cebf1 [ASoC: core - Optimise and refactor
> pcm_new() to pass only rtd] breaks compilation of txx9aclc.c:
>
> CC [M] sound/soc/txx9/txx9aclc.o
> /home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c: In function 'txx9aclc_pcm_new':
> /home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c:318:3: error: 'card' undeclared (first use in this function)
> /home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c:318:3: note: each undeclared identifier is reported only once for each function it appears in
> make[5]: *** [sound/soc/txx9/txx9aclc.o] Error 1
>
> Fixed by providing a definition for card.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Thanks, I applied now to fix/asoc branch of sound git tree.
Takashi
>
> sound/soc/txx9/txx9aclc.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/txx9/txx9aclc.c b/sound/soc/txx9/txx9aclc.c
> index 34aa972..3de99af 100644
> --- a/sound/soc/txx9/txx9aclc.c
> +++ b/sound/soc/txx9/txx9aclc.c
> @@ -290,6 +290,7 @@ static void txx9aclc_pcm_free_dma_buffers(struct snd_pcm *pcm)
>
> static int txx9aclc_pcm_new(struct snd_soc_pcm_runtime *rtd)
> {
> + struct snd_card *card = rtd->card->snd_card;
> struct snd_soc_dai *dai = rtd->cpu_dai;
> struct snd_pcm *pcm = rtd->pcm;
> struct platform_device *pdev = to_platform_device(dai->platform->dev);
>
prev parent reply other threads:[~2011-07-29 5:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 11:26 Ralf Baechle
2011-07-29 5:55 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd3gt636v.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=lrg@ti.com \
--cc=perex@perex.cz \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®