Re: [PATCH 1/3] cs5535-gpio: add AMD CS5535/CS5536 GPIO driver support

[Takashi Iwai <tiwai@suse.de>]

At Tue, 18 Aug 2009 17:53:14 -0400,
Andres Salomon wrote:
> 
> 
> This creates a CS5535/CS5536 GPIO driver which uses a gpio_chip backend
> (allowing GPIO users to use the generic GPIO API if desired) while also
> allowing architecture-specific users directly (via the cs5535_gpio_*
> functions).

Will be any user of cs5535_gpio_*() expected?  If not, it'd be better
not to export stuff, IMO.

> Tested on an OLPC machine.  Some Leemotes also use CS5536 (with a mips
> cpu), which is why this is in drivers/gpio rather than arch/x86.
> Currently, it conflicts with older geode GPIO support; once MFGPT support
> is reworked to also be more generic, the older geode code will be removed.

... or you can rewrite the old driver to use the functions above?
Then the ugly Kconfig check can be dropped, too.  (yeah that's an
answer to my own question above.)

BTW CONFIG_GPIO_CS5536 and CONFIG_CS5536_GPIO are so confusing... :)

> Signed-off-by: Andres Salomon <dilinger@collabora.co.uk>

I can happily merge this patch series to sound GIT tree if no one
objects, since it's basically for OLPC sound stuff.


thanks,

Takashi