From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757880AbZABKyI (ORCPT ); Fri, 2 Jan 2009 05:54:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754912AbZABKxz (ORCPT ); Fri, 2 Jan 2009 05:53:55 -0500 Received: from ns1.suse.de ([195.135.220.2]:54064 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239AbZABKxy (ORCPT ); Fri, 2 Jan 2009 05:53:54 -0500 Date: Fri, 02 Jan 2009 11:53:52 +0100 Message-ID: From: Takashi Iwai To: Julia Lawall Cc: perex@perex.cz, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2] sound: Use usb_set/get_intfdata In-Reply-To: References: User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 1 Jan 2009 18:14:35 +0100 (CET), Julia Lawall wrote: > > From: Julia Lawall > > Use the USB functions usb_get_intfdata and usb_set_intfdata instead of > dev_get_drvdata and dev_set_drvdata, respectively. > > The semantic patch that makes this change for the usb_get_intfdata case is > as follows: (http://www.emn.fr/x-info/coccinelle/) > > // > @header@ > @@ > > #include > > @same depends on header@ > position p; > @@ > > usb_get_intfdata@p(...) { ... } > > @depends on header@ > position _p!=same.p; > identifier _f; > struct usb_interface*intf; > @@ > > _f@_p(...) { <+... > - dev_get_drvdata(&intf->dev) > + usb_get_intfdata(intf) > ...+> } > // > > Signed-off-by: Julia Lawall Applied now. Thanks. Takashi