From: Takashi Iwai <tiwai@suse.de>
To: Bryan Wu <cooloney@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Cliff Cai <cliff.cai@analog.com>,
Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [PATCH 1/1] ALSA: add dummy function to support shared mmap in nommu Blackfin arch (v3)
Date: Wed, 03 Sep 2008 11:26:27 +0200 [thread overview]
Message-ID: <s5hd4jlpol8.wl%tiwai@suse.de> (raw)
In-Reply-To: <1220431134-7797-1-git-send-email-cooloney@kernel.org>
At Wed, 3 Sep 2008 16:38:54 +0800,
Bryan Wu wrote:
>
> From: Cliff Cai <cliff.cai@analog.com>
>
> v2-v3:
> - when it is mmu arch, we define the dummy function to NULL
>
> v1-v2:
> - only adding this dummy function in nommu arch
>
> Cc: Mike Frysinger <vapier.adi@gmail.com>
> Signed-off-by: Cliff Cai <cliff.cai@analog.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
Thanks, applied now with a slight fix of coding style.
Takashi
> ---
> sound/core/pcm_native.c | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> index c49b9d9..e2068a4 100644
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
> @@ -3391,6 +3391,16 @@ out:
> }
> #endif /* CONFIG_SND_SUPPORT_OLD_API */
>
> +#ifndef CONFIG_MMU
> +unsigned long dummy_get_unmapped_area(struct file *file, unsigned long addr,
> + unsigned long len, unsigned long pgoff, unsigned long flags)
> +{
> + return 0;
> +}
> +#else
> +# define dummy_get_unmapped_area NULL
> +#endif
> +
> /*
> * Register section
> */
> @@ -3407,6 +3417,7 @@ const struct file_operations snd_pcm_f_ops[2] = {
> .compat_ioctl = snd_pcm_ioctl_compat,
> .mmap = snd_pcm_mmap,
> .fasync = snd_pcm_fasync,
> + .get_unmapped_area = dummy_get_unmapped_area,
> },
> {
> .owner = THIS_MODULE,
> @@ -3419,5 +3430,6 @@ const struct file_operations snd_pcm_f_ops[2] = {
> .compat_ioctl = snd_pcm_ioctl_compat,
> .mmap = snd_pcm_mmap,
> .fasync = snd_pcm_fasync,
> + .get_unmapped_area = dummy_get_unmapped_area,
> }
> };
> --
> 1.5.6
>
next prev parent reply other threads:[~2008-09-03 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 8:38 Bryan Wu
2008-09-03 9:26 ` Takashi Iwai [this message]
2008-09-03 10:07 ` [alsa-devel] " Bryan Wu
2008-09-03 10:18 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd4jlpol8.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=cliff.cai@analog.com \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®