From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S936550AbYEUSxf@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S936550AbYEUSxf (ORCPT <rfc822;w@1wt.eu>);
	Wed, 21 May 2008 14:53:35 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S936339AbYEUSxI
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 21 May 2008 14:53:08 -0400
Received: from ns2.suse.de ([195.135.220.15]:33346 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S936675AbYEUSxG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 21 May 2008 14:53:06 -0400
Date: Wed, 21 May 2008 20:53:05 +0200
Message-ID: <s5hd4nfo5f2.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Gabriel C <nix.or.die@googlemail.com>,
       Linux Kernel list <linux-kernel@vger.kernel.org>,
       linux-next@vger.kernel.org, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] sound/pcmcia/vx build error
In-Reply-To: <20080521113721.a9de4700.randy.dunlap@oracle.com>
References: <48346018.5040800@googlemail.com>
	<20080521113721.a9de4700.randy.dunlap@oracle.com>
User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.7
 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki)
 (+CVS-20070806) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 21 May 2008 11:37:21 -0700,
Randy Dunlap wrote:
> 
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> menuconfig in Sound PCMCIA drivers needs to be tristate so that SND_PCMCIA
> can have a value of m so that following drivers can be restricted to m
> when needed.
> 
> sound/built-in.o: In function `vxpocket_detach':
> vxpocket.c:(.text+0x20cfa): undefined reference to `pcmcia_disable_device'
> sound/built-in.o: In function `vxpocket_probe':
> vxpocket.c:(.text+0x20f46): undefined reference to `pcmcia_request_io'
> vxpocket.c:(.text+0x20f5a): undefined reference to `pcmcia_request_irq'
> vxpocket.c:(.text+0x20f73): undefined reference to `pcmcia_request_configuration'
> vxpocket.c:(.text+0x2101f): undefined reference to `cs_error'
> vxpocket.c:(.text+0x21027): undefined reference to `pcmcia_disable_device'
> sound/built-in.o: In function `init_vxpocket':
> vxpocket.c:(.init.text+0x75b): undefined reference to `pcmcia_register_driver'
> sound/built-in.o: In function `exit_vxpocket':
> vxpocket.c:(.exit.text+0x28c): undefined reference to `pcmcia_unregister_driver'
> make: *** [.tmp_vmlinux1] Error 1
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks, applied to my tree now.


Takashi

> ---
>  sound/pcmcia/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20080521.orig/sound/pcmcia/Kconfig
> +++ linux-next-20080521/sound/pcmcia/Kconfig
> @@ -1,7 +1,7 @@
>  # ALSA PCMCIA drivers
>  
>  menuconfig SND_PCMCIA
> -	bool "PCMCIA sound devices"
> +	tristate "PCMCIA sound devices"
>  	depends on PCMCIA
>  	default y
>  	help
>