From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762911AbYEBQfw (ORCPT ); Fri, 2 May 2008 12:35:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755824AbYEBQfp (ORCPT ); Fri, 2 May 2008 12:35:45 -0400 Received: from mail.suse.de ([195.135.220.2]:43148 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754423AbYEBQfo (ORCPT ); Fri, 2 May 2008 12:35:44 -0400 Date: Fri, 02 May 2008 18:35:43 +0200 Message-ID: From: Takashi Iwai To: Stas Sergeev Cc: Linux kernel , Dmitry Torokhov Subject: Re: patch driver-core-warn-about-duplicate-driver-names-on-the-same-bus.patch added to gregkh-2.6 tree In-Reply-To: <481B3FBF.9070004@aknet.ru> References: <12094266793898@kroah.org> <4816A888.9000802@aknet.ru> <20080429045849.GA6348@suse.de> <481776EA.5010200@aknet.ru> <4818B057.4080803@aknet.ru> <481B355B.9040200@aknet.ru> <481B3FBF.9070004@aknet.ru> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 02 May 2008 20:22:23 +0400, Stas Sergeev wrote: > > Hello. > > Takashi Iwai wrote: > >> Another point is PM callbacks. Somehow > >> snd-pcsp will have to register them with > >> pcspkr. > > Hmm, isn't platform PM hook enough? > > pcspkr.c just sends an event at suspend or shutdown to the event > > handler. So, if the event was shut up at the beginning in the > > handler, nothing would be needed. > I don't think I understand what you mean... > Currently, pcspkr.c just stops the timer > counter to shut up the beep. > snd-pcsp needs more. snd_pcm_suspend_all() > for instance. Since it doesn't register > itself as a platform driver any more, he > have to register itself into pcspkr.c. > Or? If snd-pcsp can hook up input pcspkr dynamically, you can (should) register snd-pcsp as a different name, as an individual platform driver. Then the whole PM stuff would still belong to snd-pcsp. Takashi