From: Takashi Iwai <tiwai@suse.de>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org, perex@perex.cz,
alsa-devel@alsa-project.org, apw@shadowen.org,
balbir@linux.vnet.ibm.com
Subject: Re: [PATCH] mm snapshot broken-out-2007-11-20-01-45 build failer tumbler/snapper
Date: Tue, 20 Nov 2007 14:48:16 +0100 [thread overview]
Message-ID: <s5hd4u5gh9b.wl%tiwai@suse.de> (raw)
In-Reply-To: <20071120140249.GA4438@linux.vnet.ibm.com>
At Tue, 20 Nov 2007 19:32:49 +0530,
Kamalesh Babulal wrote:
>
> Hi Andrew,
>
> The kernel build fails, with following error
>
> CC sound/ppc/tumbler.o
> sound/ppc/tumbler.c: In function ‘snapper_get_capture_source’:
> sound/ppc/tumbler.c:812: error: ‘union <anonymous>’ has no member named ‘value’
> sound/ppc/tumbler.c: In function ‘snapper_put_capture_source’:
> sound/ppc/tumbler.c:824: error: ‘union <anonymous>’ has no member named ‘enuemerated’
> make[2]: *** [sound/ppc/tumbler.o] Error 1
> make[1]: *** [sound/ppc] Error 2
> make: *** [sound] Error 2
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linx.vnet.ibm.com>
Oops, thanks, that's my fault. Applied to ALSA tree now.
It didn't trigger my build check properly. I have to fix it...
Takashi
> --
> --- linux-2.6.24-rc3/sound/ppc/tumbler.c 2007-11-20 16:13:42.000000000 +0530
> +++ linux-2.6.24-rc3/sound/ppc/~tumbler.c 2007-11-20 19:14:27.000000000 +0530
> @@ -809,7 +809,7 @@ static int snapper_get_capture_source(st
> struct pmac_tumbler *mix = chip->mixer_data;
>
> snd_assert(mix, return -ENODEV);
> - ucontrol->value.enumerated.value[0] = mix->capture_source;
> + ucontrol->value.enumerated.item[0] = mix->capture_source;
> return 0;
> }
>
> @@ -821,7 +821,7 @@ static int snapper_put_capture_source(st
> int change;
>
> snd_assert(mix, return -ENODEV);
> - change = ucontrol->value.enuemerated.item[0] != mix->capture_source;
> + change = ucontrol->value.enumerated.item[0] != mix->capture_source;
> if (change) {
> mix->capture_source = !!ucontrol->value.enumerated.item[0];
> snapper_set_capture_source(mix);
>
>
> --
> Thanks & Regards,
> Kamalesh Babulal,
> Linux Technology Center,
> IBM, ISTL.
>
next prev parent reply other threads:[~2007-11-20 14:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 9:45 mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded akpm
2007-11-20 11:30 ` Kamalesh Babulal
2007-11-20 13:07 ` Thomas Gleixner
2007-11-20 14:21 ` Thomas Gleixner
2007-11-20 14:34 ` Kamalesh Babulal
2007-11-20 13:23 ` mm snapshot broken-out-2007-11-20-01-45 Build Fail - net/wireless driver Kamalesh Babulal
2007-11-27 0:59 ` Tony Breeds
2007-11-20 13:29 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded Kamalesh Babulal
2007-11-20 14:02 ` [PATCH] mm snapshot broken-out-2007-11-20-01-45 build failer tumbler/snapper Kamalesh Babulal
2007-11-20 13:48 ` Takashi Iwai [this message]
2007-11-20 14:22 ` mm snapshot broken-out-2007-11-20-01-45 Build Failure mach_apic.h Kamalesh Babulal
2007-11-20 20:31 ` Andrew Morton
2007-11-20 14:46 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz -- powerpc panic Andy Whitcroft
2007-11-20 20:35 ` Andrew Morton
2007-11-20 22:23 ` Eric W. Biederman
2007-11-20 14:48 ` [PATCH] mm snapshot broken-out-2007-11-20-01-45 Build Failure arch/x86/kernel/pci-gart_64.c Kamalesh Babulal
2007-11-20 15:18 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded Kamalesh Babulal
2007-11-20 20:50 ` Andrew Morton
2007-11-21 1:32 ` David Howells
2007-11-21 2:40 ` Andrew Morton
2007-11-21 12:49 ` David Howells
2007-11-21 16:15 ` David Howells
2007-11-20 20:34 ` Kamalesh Babulal
2007-11-20 20:48 ` Paul Moore
2007-11-20 21:31 ` Paul Moore
2007-11-20 21:18 ` mm snapshot broken-out-2007-11-20-01-45 Build Failure - macro CONFIG_THREAD_ORDER not defined Kamalesh Babulal
2007-11-20 21:41 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd4u5gh9b.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=apw@shadowen.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®