From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762367AbXH3PEd (ORCPT ); Thu, 30 Aug 2007 11:04:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762042AbXH3PER (ORCPT ); Thu, 30 Aug 2007 11:04:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58892 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761905AbXH3PEQ (ORCPT ); Thu, 30 Aug 2007 11:04:16 -0400 Date: Thu, 30 Aug 2007 17:04:14 +0200 Message-ID: From: Takashi Iwai To: Thomas Richter Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] snd_hda_intel for F/S T4210 In-Reply-To: References: User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 29 Aug 2007 17:34:19 +0200, Thomas Richter wrote: > > Hi folks, > > the patch below, to be applied to sound/pci/hda/patch_sigmatel.c fixes the audio > output on the Fujiutsu/Siemens lifebook T4210 (and probably on others). It is > suitable for the kernel 2.6.23-rc4 (and probably others). > > Without the patch, audio fails and the hda driver fails to load with > > No available DAC for pin 0x0 > > However, the indicated pin has no connections in first place and thus should be ignored. > With the patch applied audio output works fine. The problem is that nid = 0 is used. So, your patch just hides another bug. Please check whether the bug still exists with git.kernel.org perex/alsa.git mm branch. If still there, build with CONFIG_SND_DEBUG and show the autoconfig output. thanks, Takashi > > Here's the patch: > > /* snip */ > --- patch_sigmatel_old.c 2007-08-29 17:17:51.000000000 +0200 > +++ patch_sigmatel.c 2007-08-29 17:21:25.000000000 +0200 > @@ -1250,6 +1250,16 @@ > nid = cfg->line_out_pins[i]; > conn_len = snd_hda_get_connections(codec, nid, conn, > HDA_MAX_CONNECTIONS); > + /* FIX THOR: For some hardware (notably the Fujiutsu/Siemens T4210 > + ** lifebook), we have nids with no pins whatsoever. Ignore > + ** them. > + */ > + if (conn_len == 0) { > + snd_printk(KERN_ERR "%s: Found zero connections for pin 0x%0x " > + "ignoring it.\n",__func__,nid); > + continue; > + } > + > for (j = 0; j < conn_len; j++) { > wcaps = snd_hda_param_read(codec, conn[j], > AC_PAR_AUDIO_WIDGET_CAP); > /* snip */ > > Greetings, > Thomas > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >