mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jaroslav Kysela <perex@suse.cz>
Cc: Linus Torvalds <torvalds@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [ALSA PATCH] alsa-git merge request
Date: Fri, 09 Feb 2007 16:00:44 +0100	[thread overview]
Message-ID: <s5hd54jnzoj.wl%tiwai@suse.de> (raw)
In-Reply-To: <s5hejozo0al.wl%tiwai@suse.de>

At Fri, 09 Feb 2007 15:47:30 +0100,
I wrote:
> 
> At Fri, 9 Feb 2007 15:40:21 +0100 (CET),
> Jaroslav Kysela wrote:
> > 
> > On Fri, 9 Feb 2007, Takashi Iwai wrote:
> > 
> > > At Fri, 9 Feb 2007 15:02:05 +0100 (CET),
> > > Jaroslav Kysela wrote:
> > > > 
> > > > Linus, please do an update from:
> > > > 
> > > >   http://www.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git
> > > >   (linus branch)
> > > 
> > > Jaroslav, as I wrote you many times, this tree includes the wrong
> > > patches!  If it's merged, we'd need fix patches in addition
> > > eventually...
> > 
> > I replaced patches with your code a few days ago. If something else is 
> > broken, please, let me know.
> 
> Strange, my local tree freshly pulled have old files.
> I'll try to pull cleanly and check again.

Reconfirmed that it's still broken.  The below is a patch to fix.
Please apply.


thanks,

Takashi

===

[PATCH] Fix breakage with CONFIG_SYSFS_DEPRECATED

The fix for sysfs breakage with CONFIG_SYSFS_DEPRECATED was flown
away by the conflicted merge of the ALSA git tree.  The patch below
fixes it again.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 include/sound/core.h |    2 +-
 sound/core/pcm.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/sound/core.h b/include/sound/core.h
index 3c493ad..4b9e609 100644
--- a/include/sound/core.h
+++ b/include/sound/core.h
@@ -242,7 +242,7 @@ static inline int snd_register_device(in
 {
 	return snd_register_device_for_dev(type, card, dev, f_ops,
 					   private_data, name,
-					   card ? card->dev : NULL);
+					   snd_card_get_device_link(card));
 }
 
 int snd_unregister_device(int type, struct snd_card *card, int dev);
diff --git a/sound/core/pcm.c b/sound/core/pcm.c
index 76fcc52..2743414 100644
--- a/sound/core/pcm.c
+++ b/sound/core/pcm.c
@@ -968,7 +968,7 @@ static int snd_pcm_dev_register(struct s
 		 * if possible */
 		dev = pcm->dev;
 		if (!dev)
-			dev = pcm->card ? pcm->card->dev : NULL;
+			dev = snd_card_get_device_link(pcm->card);
 		/* register pcm */
 		err = snd_register_device_for_dev(devtype, pcm->card,
 						  pcm->device,

  reply	other threads:[~2007-02-09 15:00 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 14:02 Jaroslav Kysela
2007-02-09 14:15 ` Takashi Iwai
2007-02-09 14:40   ` Jaroslav Kysela
2007-02-09 14:47     ` Takashi Iwai
2007-02-09 15:00       ` Takashi Iwai [this message]
2007-02-09 15:30         ` Jaroslav Kysela
2007-02-09 15:58   ` Linus Torvalds
2007-02-09 16:07     ` Jaroslav Kysela
  -- strict thread matches above, loose matches on Subject: below --
2008-10-10 12:12 Jaroslav Kysela
2008-10-11 10:21 ` Takashi Iwai
2008-07-14  9:09 Jaroslav Kysela
2008-08-24 21:30 ` Guillaume Chazarain
2008-08-25  5:50   ` Takashi Iwai
2008-08-25 21:36     ` Guillaume Chazarain
2008-08-25 22:43       ` Guillaume Chazarain
2008-08-26  5:59         ` Takashi Iwai
2008-08-26 21:10           ` Guillaume Chazarain
2008-08-27  6:02             ` Takashi Iwai
2008-01-31 17:04 Jaroslav Kysela
2008-01-31 23:24 ` Linus Torvalds
2007-11-19 18:35 Jaroslav Kysela
2007-11-20  6:48 ` Takashi Iwai
2007-11-20 19:20   ` Jaroslav Kysela
2007-10-23  6:14 Jaroslav Kysela
2007-10-16 15:08 Jaroslav Kysela
2007-07-20  9:39 Jaroslav Kysela
2007-05-31  9:07 Jaroslav Kysela
2007-05-16  9:50 Jaroslav Kysela
2007-05-09  9:59 Jaroslav Kysela
2007-05-03 12:51 Jaroslav Kysela
2007-03-14  7:28 Jaroslav Kysela
2007-03-06 14:20 Jaroslav Kysela
2007-02-14  7:46 Jaroslav Kysela
2007-02-14 17:53 ` Linus Torvalds
2007-01-23  8:31 Jaroslav Kysela
2007-01-09 14:04 Jaroslav Kysela
2006-12-20  8:52 Jaroslav Kysela
2006-12-15  7:52 Jaroslav Kysela
2006-12-15  8:13 ` Andrew Morton
2006-12-15  8:17   ` Andrew Morton
2006-12-15  8:44     ` Jaroslav Kysela
2006-12-15  8:45   ` Jaroslav Kysela
2006-12-15 16:00 ` Linus Torvalds
2006-11-28 14:11 Jaroslav Kysela
2006-10-22  9:09 Jaroslav Kysela
2006-10-06 18:27 Jaroslav Kysela
2006-09-23  9:23 Jaroslav Kysela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hd54jnzoj.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®